Details

Reviewers

trasz
slm

Group Reviewers

cam

Summary

Create a new function xpt_setup_stack_ccb which is used to setup a ccb
that lives on the stack.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39302
Build 36191: arc lint + arc unit

Event Timeline

imp created this revision.May 20 2021, 2:15 AM

Herald added a reviewer: cam. · View Herald TranscriptMay 20 2021, 2:15 AM

imp requested review of this revision.May 20 2021, 2:15 AM

Harbormaster completed remote builds in B39296: Diff 89494.May 20 2021, 2:15 AM

imp mentioned this in D30300: pms(4): clear CCBs allocated on the stack.May 20 2021, 2:16 AM

imp edited the test plan for this revision. (Show Details)

imp added a reviewer: trasz.

Add malloc tagging and add assert to xpt_setup_ccb

Harbormaster completed remote builds in B39297: Diff 89495.May 20 2021, 2:21 AM

Note: this just does scsi_da.c as a proof of concept, but doesn't go through the tree yet.

imp added a comment.May 20 2021, 5:01 AM

This comment was removed by imp.

https://reviews.freebsd.org/D30353 has all the other changes, and a good coccinelle script for spatch

tweak the script to eliminate a couple of bugs

Herald added a reviewer: slm. · View Herald TranscriptMay 20 2021, 5:52 AM

Herald added subscribers: dab, jhibbits. · View Herald Transcript

Harbormaster completed remote builds in B39301: Diff 89499.May 20 2021, 5:52 AM

better script

Harbormaster completed remote builds in B39302: Diff 89501.May 20 2021, 5:59 AM

oops, regen with right patch

Harbormaster completed remote builds in B39303: Diff 89503.May 20 2021, 6:04 AM

assert we're not freeing a stack thing
Get the names of the field right

Harbormaster completed remote builds in B39316: Diff 89546.May 20 2021, 5:18 PM

I still like this idea, but I think that I'm just going to punt on this detail

cam: introduce xpt_setup_stack_ccbAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 89501

sys/cam/ata/ata_da.c

sys/cam/ata/ata_pmp.c

sys/cam/ata/ata_xpt.c

sys/cam/cam_ccb.h

sys/cam/cam_periph.c

sys/cam/cam_xpt.h

sys/cam/cam_xpt.c

sys/cam/ctl/scsi_ctl.c

sys/cam/mmc/mmc_da.c

sys/cam/mmc/mmc_xpt.c

sys/cam/nvme/nvme_da.c

sys/cam/nvme/nvme_xpt.c

sys/cam/scsi/scsi_cd.c

sys/cam/scsi/scsi_da.c

sys/cam/scsi/scsi_enc_ses.c

sys/cam/scsi/scsi_sa.c

sys/cam/scsi/scsi_targ_bh.c

sys/cam/scsi/scsi_target.c

sys/cam/scsi/scsi_xpt.c

sys/dev/aic7xxx/aic79xx_osm.c

sys/dev/aic7xxx/aic7xxx_osm.c

sys/dev/arcmsr/arcmsr.c

sys/dev/hpt27xx/hpt27xx_osm_bsd.c

sys/dev/hptiop/hptiop.c

sys/dev/hptnr/hptnr_osm_bsd.c

sys/dev/hptrr/hptrr_osm_bsd.c

sys/dev/isci/isci_io_request.c

sys/dev/mpr/mpr_sas.c

sys/dev/mps/mps_sas.c

sys/dev/mpt/mpt_cam.c

sys/dev/mpt/mpt_raid.c

sys/dev/pms/freebsd/driver/ini/src/agtiapi.c

sys/dev/smartpqi/smartpqi_cam.c

sys/dev/sym/sym_hipd.c

sys/dev/virtio/scsi/virtio_scsi.c

sys/powerpc/ps3/ps3cdrom.c

cam: introduce xpt_setup_stack_ccb
AbandonedPublic
Actions

Revision Contents
Changeset List