Page MenuHomeFreeBSD
Differential D3699

Eliminate nd6_nud_hint() and its TCP bindings.
ClosedPublic
Actions

Authored by melifaro on Sep 20 2015, 3:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 9:38 AM
Unknown Object (File)
Thu, Feb 27, 8:26 PM
Unknown Object (File)
Thu, Feb 20, 5:59 PM
Unknown Object (File)
Thu, Feb 20, 5:33 PM
Unknown Object (File)
Feb 4 2025, 4:19 PM
Unknown Object (File)
Nov 29 2024, 9:10 PM
Unknown Object (File)
Nov 21 2024, 5:25 PM
Unknown Object (File)
Nov 17 2024, 4:12 AM
View All Files
Subscribers
imp

Details

Reviewers
hrs
gnn
Group Reviewers
network
Commits
rS288301: Eliminate nd6_nud_hint() and its TCP bindings.
Summary

Initially function was introduced in r53541 (KAME initial commit) to "provide hints from upper layer protocols that indicate a connection is making "forward progress"" (quote from RFC 2461 7.3.1 Reachability Confirmation).
However, it was converted to do nothing (e.g. just return) in r122922 (tcp_hostcache implementation) back in 2003. Some defines were moved to tcp_var.h in r169541. Then, it was broken (for non-corner cases) by r186119 (L2<>L3 split) in 2008 (NULL ifp in nd6_lookup). So, right now this code is broken and has no "real" base users.

Even if ability to provide reachability hint from upper-layer protocol like TCP might sound as a good idea, it is not trivial to do efficient implementation. Personally I don't think it is needed ATM - if one really needs to reduce number of ND confirmations, "basereachable" variable can be increased to sufficient value. Given that, I'd like to remove the part of code in question.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 617
Build 617: arc lint + arc unit

Event Timeline

melifaro updated this revision to Diff 8849.Sep 20 2015, 3:14 PM
melifaro retitled this revision from to Eliminate nd6_nud_hint() and its TCP bindings..
melifaro updated this object.
melifaro edited the test plan for this revision. (Show Details)
melifaro added a reviewer: network.
Herald added a subscriber: imp. · View Herald TranscriptSep 20 2015, 3:14 PM
hrs accepted this revision.Sep 20 2015, 5:45 PM
hrs added a reviewer: hrs.
This revision is now accepted and ready to land.Sep 20 2015, 5:45 PM
gnn accepted this revision.Sep 22 2015, 8:38 PM
gnn added a reviewer: gnn.
melifaro updated this revision to Diff 8950.Sep 27 2015, 5:12 AM
melifaro edited edge metadata.

Do pre-commit sync.

This revision now requires review to proceed.Sep 27 2015, 5:12 AM
melifaro updated this revision to Diff 8951.Sep 27 2015, 5:18 AM
melifaro edited edge metadata.

Remove non-relevant __noinline definitions.

Closed by commit rS288301: Eliminate nd6_nud_hint() and its TCP bindings. (authored by melifaro). · Explain WhySep 27 2015, 5:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
net/
1 line
1 line
netinet/
15 lines
1 line
12 lines
netinet6/
1 line
43 lines
12 lines

Diff 8950

View Options

sys/net/if_llatbl.h

Show First 20 Lines • Show All 54 Lines • ▼ Show 20 Lines
* head/en_US.ISO8859-1/books/porters-handbook/versions/chapter.xml * head/en_US.ISO8859-1/books/porters-handbook/versions/chapter.xml
* *
* scheme is: <major><two digit minor>Rxx * scheme is: <major><two digit minor>Rxx
* 'R' is in the range 0 to 4 if this is a release branch or * 'R' is in the range 0 to 4 if this is a release branch or
* X.0-CURRENT before releng/X.0 is created, otherwise 'R' is * X.0-CURRENT before releng/X.0 is created, otherwise 'R' is
* in the range 5 to 9. * in the range 5 to 9.
*/ */
#undef __FreeBSD_version #undef __FreeBSD_version
#define __FreeBSD_version 1300040 /* Master, propagated to newvers */ #define __FreeBSD_version 1300041 /* Master, propagated to newvers */
/* /*
* __FreeBSD_kernel__ indicates that this system uses the kernel of FreeBSD, * __FreeBSD_kernel__ indicates that this system uses the kernel of FreeBSD,
* which by definition is always true on FreeBSD. This macro is also defined * which by definition is always true on FreeBSD. This macro is also defined
* on other systems that use the kernel of FreeBSD, such as GNU/kFreeBSD. * on other systems that use the kernel of FreeBSD, such as GNU/kFreeBSD.
* *
* It is tempting to use this macro in userland code when we want to enable * It is tempting to use this macro in userland code when we want to enable
* kernel-specific routines, and in fact it's fine to do this in code that * kernel-specific routines, and in fact it's fine to do this in code that
▲ Show 20 Lines • Show All 296 Lines • Show Last 20 Lines
View Options

sys/net/if_llatbl.c

Show First 20 Lines • Show All 54 Lines • ▼ Show 20 Lines
* head/en_US.ISO8859-1/books/porters-handbook/versions/chapter.xml * head/en_US.ISO8859-1/books/porters-handbook/versions/chapter.xml
* *
* scheme is: <major><two digit minor>Rxx * scheme is: <major><two digit minor>Rxx
* 'R' is in the range 0 to 4 if this is a release branch or * 'R' is in the range 0 to 4 if this is a release branch or
* X.0-CURRENT before releng/X.0 is created, otherwise 'R' is * X.0-CURRENT before releng/X.0 is created, otherwise 'R' is
* in the range 5 to 9. * in the range 5 to 9.
*/ */
#undef __FreeBSD_version #undef __FreeBSD_version
#define __FreeBSD_version 1300040 /* Master, propagated to newvers */ #define __FreeBSD_version 1300041 /* Master, propagated to newvers */
/* /*
* __FreeBSD_kernel__ indicates that this system uses the kernel of FreeBSD, * __FreeBSD_kernel__ indicates that this system uses the kernel of FreeBSD,
* which by definition is always true on FreeBSD. This macro is also defined * which by definition is always true on FreeBSD. This macro is also defined
* on other systems that use the kernel of FreeBSD, such as GNU/kFreeBSD. * on other systems that use the kernel of FreeBSD, such as GNU/kFreeBSD.
* *
* It is tempting to use this macro in userland code when we want to enable * It is tempting to use this macro in userland code when we want to enable
* kernel-specific routines, and in fact it's fine to do this in code that * kernel-specific routines, and in fact it's fine to do this in code that
▲ Show 20 Lines • Show All 296 Lines • Show Last 20 Lines
View Options

sys/netinet/tcp_input.c

Show First 20 Lines • Show All 54 Lines • ▼ Show 20 Lines
* head/en_US.ISO8859-1/books/porters-handbook/versions/chapter.xml * head/en_US.ISO8859-1/books/porters-handbook/versions/chapter.xml
* *
* scheme is: <major><two digit minor>Rxx * scheme is: <major><two digit minor>Rxx
* 'R' is in the range 0 to 4 if this is a release branch or * 'R' is in the range 0 to 4 if this is a release branch or
* X.0-CURRENT before releng/X.0 is created, otherwise 'R' is * X.0-CURRENT before releng/X.0 is created, otherwise 'R' is
* in the range 5 to 9. * in the range 5 to 9.
*/ */
#undef __FreeBSD_version #undef __FreeBSD_version
#define __FreeBSD_version 1300040 /* Master, propagated to newvers */ #define __FreeBSD_version 1300041 /* Master, propagated to newvers */
/* /*
* __FreeBSD_kernel__ indicates that this system uses the kernel of FreeBSD, * __FreeBSD_kernel__ indicates that this system uses the kernel of FreeBSD,
* which by definition is always true on FreeBSD. This macro is also defined * which by definition is always true on FreeBSD. This macro is also defined
* on other systems that use the kernel of FreeBSD, such as GNU/kFreeBSD. * on other systems that use the kernel of FreeBSD, such as GNU/kFreeBSD.
* *
* It is tempting to use this macro in userland code when we want to enable * It is tempting to use this macro in userland code when we want to enable
* kernel-specific routines, and in fact it's fine to do this in code that * kernel-specific routines, and in fact it's fine to do this in code that
▲ Show 20 Lines • Show All 296 Lines • Show Last 20 Lines
View Options

sys/netinet/tcp_reass.c

Show First 20 Lines • Show All 54 Lines • ▼ Show 20 Lines
* head/en_US.ISO8859-1/books/porters-handbook/versions/chapter.xml * head/en_US.ISO8859-1/books/porters-handbook/versions/chapter.xml
* *
* scheme is: <major><two digit minor>Rxx * scheme is: <major><two digit minor>Rxx
* 'R' is in the range 0 to 4 if this is a release branch or * 'R' is in the range 0 to 4 if this is a release branch or
* X.0-CURRENT before releng/X.0 is created, otherwise 'R' is * X.0-CURRENT before releng/X.0 is created, otherwise 'R' is
* in the range 5 to 9. * in the range 5 to 9.
*/ */
#undef __FreeBSD_version #undef __FreeBSD_version
#define __FreeBSD_version 1300040 /* Master, propagated to newvers */ #define __FreeBSD_version 1300041 /* Master, propagated to newvers */
/* /*
* __FreeBSD_kernel__ indicates that this system uses the kernel of FreeBSD, * __FreeBSD_kernel__ indicates that this system uses the kernel of FreeBSD,
* which by definition is always true on FreeBSD. This macro is also defined * which by definition is always true on FreeBSD. This macro is also defined
* on other systems that use the kernel of FreeBSD, such as GNU/kFreeBSD. * on other systems that use the kernel of FreeBSD, such as GNU/kFreeBSD.
* *
* It is tempting to use this macro in userland code when we want to enable * It is tempting to use this macro in userland code when we want to enable
* kernel-specific routines, and in fact it's fine to do this in code that * kernel-specific routines, and in fact it's fine to do this in code that
▲ Show 20 Lines • Show All 296 Lines • Show Last 20 Lines
View Options

sys/netinet/tcp_var.h

Loading...
View Options

sys/netinet6/nd6.h

Loading...
View Options

sys/netinet6/nd6.c

Loading...
View Options

sys/netinet6/nd6_nbr.c

Loading...