More exception.S changes
ClosedPublic
Actions

Authored by kib on Sep 22 2015, 4:55 PM.

Details

Reviewers

emaste
andrew

Commits

rS288123: Call ast when handling irq from userspace, otherwise we could miss

Summary

Call ast when handling irq from userspace, otherwise we could miss reschedule. Right now arm_cpu_intr() does critical_exit() as the last action, so the impact is not serious.

Keep interrupts disabled after do_ast, otherwise we might miss reschedule if interrupt is delivered after the ast handler called.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib updated this revision to Diff 8890.Sep 22 2015, 4:55 PM

kib retitled this revision from to More exception.S changes.

kib updated this object.

kib edited the test plan for this revision. (Show Details)

kib added reviewers: andrew, emaste.

kib set the repository for this revision to rS FreeBSD src repository - subversion.

kib added a project: arm64.

Herald added a subscriber: imp. · View Herald TranscriptSep 22 2015, 4:55 PM

Re-merge after r288117. Part of the previous patch was consumed by the commit.

Use full context for diff.

andrew accepted this revision.Sep 22 2015, 5:57 PM

andrew edited edge metadata.

andrew added inline comments.

sys/arm64/arm64/exception.S
118–119 ↗	(On Diff #8893)	This could be written as and x2, x2, x3 cbz x2, 2f

This revision is now accepted and ready to land.Sep 22 2015, 5:57 PM

Closed by commit rS288123: Call ast when handling irq from userspace, otherwise we could miss (authored by kib). · Explain WhySep 22 2015, 6:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

arm64/

exception.S

10 lines

Diff 8897

View Options

head/sys/arm64/arm64/exception.S

More exception.S changesClosedPublicActions