Page MenuHomeFreeBSD
Differential D30008

netgraph/ng_bridge: Handle send errors during loop processing
ClosedPublic
Actions

Authored by donner on Apr 27 2021, 7:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 14, 6:34 AM
Unknown Object (File)
Thu, May 14, 2:32 AM
Unknown Object (File)
Thu, May 14, 1:42 AM
Unknown Object (File)
Wed, May 13, 6:38 PM
Unknown Object (File)
Wed, May 13, 6:36 PM
Unknown Object (File)
Mon, May 11, 11:55 AM
Unknown Object (File)
Mon, May 11, 4:12 AM
Unknown Object (File)
Mon, May 11, 3:18 AM
View All Files
Subscribers
imp
julian
melifaro
Contributor Reviews (src)

Details

Reviewers
None
Group Reviewers
network
Commits
rG1165cafa0bae: netgraph/ng_bridge: Handle send errors during loop handling
rGe240dd0d502e: netgraph/ng_bridge: Handle send errors during loop handling
rGa56e5ad69030: netgraph/ng_bridge: Handle send errors during loop handling
Summary

If sending out a packet fails during the loop over all links, the
allocated memory is leaked and not all links receive a copy. This
patch fixes those problems, clarifies a premature abort of the loop,
and fixes a minory style(9) bug.

PR: 255430
MFC: 1 week
Submitted by: Dancho Penev

Test Plan

Build a bridge over a bunch of ng_eiface(4). Set one of the
interfaces down (causing the error), try to send out a broadcast
packet and monitor all the interfaces.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 38885
Build 35774: arc lint + arc unit

Event Timeline

donner created this revision.Apr 27 2021, 7:58 AM
Herald added subscribers: Contributor Reviews (src), melifaro, imp. · View Herald TranscriptApr 27 2021, 7:58 AM
donner requested review of this revision.Apr 27 2021, 7:58 AM
Harbormaster completed remote builds in B38885: Diff 88243.Apr 27 2021, 7:58 AM
donner updated this revision to Diff 88246.Apr 27 2021, 8:05 AM
  • Free packet if not send at all.
Harbormaster completed remote builds in B38888: Diff 88246.Apr 27 2021, 8:05 AM
donner added a reviewer: network.Apr 27 2021, 8:18 AM
donner retitled this revision from netgraph/ng_bridge: Handle send errors during loop handling to netgraph/ng_bridge: Handle send errors during loop processing.Apr 27 2021, 11:11 AM
donner edited the summary of this revision. (Show Details)
julian added a subscriber: julian.May 1 2021, 12:30 PM
julian added inline comments.
sys/netgraph/ng_bridge.c
655

I would do: if error ( error stuff; return error} followed by the non error case continuing on with one level less indent. just a style thing.. result is the same

donner updated this revision to Diff 88476.May 1 2021, 7:49 PM
  • Restructure the error handling in a more common way.
Harbormaster completed remote builds in B38956: Diff 88476.May 1 2021, 7:49 PM
donner marked an inline comment as done.May 1 2021, 7:51 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 13 2021, 7:51 PM
Closed by commit rGa56e5ad69030: netgraph/ng_bridge: Handle send errors during loop handling (authored by donner). · Explain Why
This revision was automatically updated to reflect the committed changes.
donner added a commit: rGa56e5ad69030: netgraph/ng_bridge: Handle send errors during loop handling.
donner added a commit: rGe240dd0d502e: netgraph/ng_bridge: Handle send errors during loop handling.May 20 2021, 5:54 AM
donner added a commit: rG1165cafa0bae: netgraph/ng_bridge: Handle send errors during loop handling.May 20 2021, 6:00 AM

Revision Contents
Changeset List

PathSize
sys/
netgraph/
28 lines

Diff 88243

View Options

sys/netgraph/ng_bridge.c

Loading...