Page MenuHomeFreeBSD

aesni: Avoid modifying session keys in hmac_update()
ClosedPublic

Authored by markj on Apr 27 2021, 12:19 AM.
Tags
None
Referenced Files
F135414308: D30001.id.diff
Sun, Nov 9, 3:56 PM
Unknown Object (File)
Fri, Nov 7, 3:51 PM
Unknown Object (File)
Fri, Nov 7, 10:44 AM
Unknown Object (File)
Wed, Oct 22, 8:06 AM
Unknown Object (File)
Sep 24 2025, 3:31 PM
Unknown Object (File)
Sep 9 2025, 12:12 PM
Unknown Object (File)
Sep 4 2025, 5:42 AM
Unknown Object (File)
Aug 15 2025, 11:43 AM
Subscribers
None

Details

Summary

Otherwise aesni_process() is not thread-safe for AES+SHA-HMAC
transforms, since hmac_update() updates the caller-supplied key directly
to create the derived key. Use a buffer on the stack to store a copy of
the key used for computing inner and outer digests.

Note that this applies to stable/12 only.

Diff Detail

Repository
rG FreeBSD src repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 38878
Build 35767: arc lint + arc unit

Event Timeline

markj created this revision.
This revision is now accepted and ready to land.Apr 27 2021, 2:09 PM