Page MenuHomeFreeBSD

aesni: Avoid modifying session keys in hmac_update()
ClosedPublic

Authored by markj on Apr 27 2021, 12:19 AM.
Tags
None
Referenced Files
F87862279: D30001.diff
Mon, Jul 8, 10:40 PM
Unknown Object (File)
Thu, Jun 27, 4:56 AM
Unknown Object (File)
Tue, Jun 25, 8:47 AM
Unknown Object (File)
Sat, Jun 22, 11:13 PM
Unknown Object (File)
Fri, Jun 21, 4:46 AM
Unknown Object (File)
Thu, Jun 20, 10:53 AM
Unknown Object (File)
Thu, Jun 20, 10:45 AM
Unknown Object (File)
May 6 2024, 10:20 PM
Subscribers
None

Details

Summary

Otherwise aesni_process() is not thread-safe for AES+SHA-HMAC
transforms, since hmac_update() updates the caller-supplied key directly
to create the derived key. Use a buffer on the stack to store a copy of
the key used for computing inner and outer digests.

Note that this applies to stable/12 only.

Diff Detail

Repository
rG FreeBSD src repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 38878
Build 35767: arc lint + arc unit

Event Timeline

markj created this revision.
This revision is now accepted and ready to land.Apr 27 2021, 2:09 PM