imgact_elf: Ensure that the return value in parse_notes is initialized
ClosedPublic
Actions

Authored by markj on Apr 25 2021, 11:50 PM.

Details

Reviewers

Commits

rG0048a3237ddb: imgact_elf: Ensure that the return value in parse_notes is initialized
rG67dc1da8f32a: imgact_elf: Ensure that the return value in parse_notes is initialized
rG409ab7e109c6: imgact_elf: Ensure that the return value in parse_notes is initialized

Summary

parse_notes relies on the caller-supplied callback to initialize "res".
Two callbacks are used in practice, brandnote_cb and note_fctl_cb, and
the latter fails to initialize res. Try to fix it.

Reported by: KMSAN

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 38857
Build 35746: arc lint + arc unit

Event Timeline

markj created this revision.Apr 25 2021, 11:50 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 25 2021, 11:50 PM

markj requested review of this revision.Apr 25 2021, 11:50 PM

Harbormaster completed remote builds in B38857: Diff 88143.Apr 25 2021, 11:50 PM

I.e. the only effect of this was that the inner loop from check_note potentially did not stopped after fctl note was handled, but continued till the end of the phdrs.

This revision is now accepted and ready to land.Apr 26 2021, 12:03 AM

In D29986#672701, @kib wrote:

I.e. the only effect of this was that the inner loop from check_note potentially did not stopped after fctl note was handled, but continued till the end of the phdrs.

I think so, yes. I will note this in the commit message.

Closed by commit rG409ab7e109c6: imgact_elf: Ensure that the return value in parse_notes is initialized (authored by markj). · Explain WhyApr 26 2021, 6:55 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG409ab7e109c6: imgact_elf: Ensure that the return value in parse_notes is initialized.

markj added a commit: rG67dc1da8f32a: imgact_elf: Ensure that the return value in parse_notes is initialized.May 3 2021, 12:36 PM

markj added a commit: rG0048a3237ddb: imgact_elf: Ensure that the return value in parse_notes is initialized.May 3 2021, 12:39 PM