Page MenuHomeFreeBSD
Differential D29927

linux(4): fix ptrace(2) to properly handle orig_rax
ClosedPublic
Actions

Authored by trasz on Apr 22 2021, 3:25 PM.
Tags
None
Referenced Files
F154284348: D29927.id87980.diff
Mon, Apr 27, 2:40 PM
Unknown Object (File)
Tue, Apr 21, 5:49 AM
Unknown Object (File)
Mon, Apr 20, 9:35 PM
Unknown Object (File)
Mon, Apr 20, 3:03 PM
Unknown Object (File)
Mon, Apr 13, 9:16 PM
Unknown Object (File)
Mon, Apr 13, 5:44 AM
Unknown Object (File)
Tue, Apr 7, 6:36 AM
Unknown Object (File)
Tue, Apr 7, 4:54 AM
View All Files
Subscribers
emaste
imp

Details

Reviewers
jhb
Group Reviewers
Linux Emulation
Commits
rG1f948bb41f7e: linux(4): fix ptrace(2) to properly handle orig_rax
rG023bff799098: linux(4): fix ptrace(2) to properly handle orig_rax
Summary

This should fix strace(1) erroneously reporting return values
as "Function not implemented", combined with reporting the binary
ABI as X32.

Very similar code in linux_ptrace_getregs() is left as it is - it might
be wrong, but I don't have a way to test it.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 38805
Build 35694: arc lint + arc unit

Event Timeline

trasz created this revision.Apr 22 2021, 3:25 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptApr 22 2021, 3:25 PM
trasz requested review of this revision.Apr 22 2021, 3:25 PM
Harbormaster completed remote builds in B38805: Diff 87980.Apr 22 2021, 3:25 PM
trasz added reviewers: Linux Emulation, jhb.Apr 22 2021, 3:25 PM
trasz edited the summary of this revision. (Show Details)Apr 22 2021, 3:28 PM
jhb added a comment.Apr 22 2021, 10:00 PM

In general Linux extends GPR regsets with 'orig_foo' that stores the syscall code. Presumably i386 should be doing the same for orig_eax?

trasz added a comment.Apr 23 2021, 2:38 PM
In D29927#671791, @jhb wrote:

In general Linux extends GPR regsets with 'orig_foo' that stores the syscall code. Presumably i386 should be doing the same for orig_eax?

Perhaps, but I don't have an easy way to test i386 either.

trasz added a comment.Apr 29 2021, 11:29 AM

(Tinderboxed.)

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2021, 2:21 PM
Closed by commit rG023bff799098: linux(4): fix ptrace(2) to properly handle orig_rax (authored by trasz). · Explain Why
This revision was automatically updated to reflect the committed changes.
trasz added a commit: rG023bff799098: linux(4): fix ptrace(2) to properly handle orig_rax.
trasz added a commit: rG1f948bb41f7e: linux(4): fix ptrace(2) to properly handle orig_rax.Feb 21 2022, 1:49 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
linux/
16 lines

Diff 87980

View Options

sys/amd64/linux/linux_ptrace.c

Loading...