Page MenuHomeFreeBSD

linux(4): fix ptrace(2) to properly handle orig_rax
ClosedPublic

Authored by trasz on Apr 22 2021, 3:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 14, 7:28 AM
Unknown Object (File)
Tue, Oct 14, 3:01 AM
Unknown Object (File)
Mon, Oct 13, 5:48 PM
Unknown Object (File)
Mon, Oct 13, 5:48 PM
Unknown Object (File)
Mon, Oct 13, 4:27 AM
Unknown Object (File)
Wed, Oct 8, 11:58 PM
Unknown Object (File)
Sat, Sep 20, 11:14 PM
Unknown Object (File)
Jul 28 2025, 11:25 PM
Subscribers

Details

Summary

This should fix strace(1) erroneously reporting return values
as "Function not implemented", combined with reporting the binary
ABI as X32.

Very similar code in linux_ptrace_getregs() is left as it is - it might
be wrong, but I don't have a way to test it.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trasz requested review of this revision.Apr 22 2021, 3:25 PM

In general Linux extends GPR regsets with 'orig_foo' that stores the syscall code. Presumably i386 should be doing the same for orig_eax?

In D29927#671791, @jhb wrote:

In general Linux extends GPR regsets with 'orig_foo' that stores the syscall code. Presumably i386 should be doing the same for orig_eax?

Perhaps, but I don't have an easy way to test i386 either.

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2021, 2:21 PM
This revision was automatically updated to reflect the committed changes.