Page MenuHomeFreeBSD
Differential D27204

getprogname.3: Show difference between getprogname() and argv[0] in an example
ClosedPublic
Actions

Authored by 0mp on Nov 13 2020, 1:36 PM.
Tags
None
Referenced Files
F148603522: D27204.id87637.diff
Thu, Mar 19, 2:20 AM
Unknown Object (File)
Wed, Mar 18, 12:28 AM
Unknown Object (File)
Tue, Mar 17, 9:42 AM
Unknown Object (File)
Mon, Mar 16, 6:10 AM
Unknown Object (File)
Sun, Mar 15, 10:54 AM
Unknown Object (File)
Sat, Mar 14, 11:20 PM
Unknown Object (File)
Sat, Mar 14, 9:57 PM
Unknown Object (File)
Fri, Mar 13, 7:38 PM
View All Files
Subscribers
gbe
imp
yuripv

Details

Reviewers
yuripv
Group Reviewers
manpages
Commits
rG2e34e54d4bf5: getprogname.3: Add an example
rG5cdee2441ed9: getprogname.3: Add an example
rG1ffdcdadf614: getprogname.3: Add an example
Summary
Show difference between getprogname() and argv[0] in an example

MFC:	2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

0mp created this revision.Nov 13 2020, 1:36 PM
Herald added a reviewer: manpages. · View Herald TranscriptNov 13 2020, 1:36 PM
Herald added a subscriber: imp. · View Herald Transcript
0mp requested review of this revision.Nov 13 2020, 1:36 PM
Harbormaster completed remote builds in B34779: Diff 79501.Nov 13 2020, 1:37 PM
yuripv added a subscriber: yuripv.Nov 22 2020, 5:23 PM
yuripv added inline comments.
lib/libc/gen/getprogname.3
97
yuripv added inline comments.Nov 22 2020, 5:25 PM
lib/libc/gen/getprogname.3
88
104
0mp updated this revision to Diff 79908.Nov 23 2020, 5:53 PM

Fix typos reported by yuripv

Harbormaster completed remote builds in B34985: Diff 79908.Nov 23 2020, 5:53 PM
0mp marked 3 inline comments as done.Nov 23 2020, 5:53 PM
yuripv added inline comments.Nov 23 2020, 8:00 PM
lib/libc/gen/getprogname.3
98

Sorry, still doesn't look completely right, just trying to follow what style(9) says :)

The function type should be on a line by itself preceding the function.
The opening brace of the function body should be on a line by itself.

static char *
function(int a1, int a2, float fl, int a4, struct bar *bar)
{
gbe added a subscriber: gbe.Jan 9 2021, 1:48 PM
0mp updated this revision to Diff 87637.Apr 17 2021, 9:27 PM

Fix style(9) issues

Harbormaster completed remote builds in B38659: Diff 87637.Apr 17 2021, 9:27 PM
0mp marked an inline comment as done.Apr 17 2021, 9:28 PM
0mp added inline comments.
lib/libc/gen/getprogname.3
98

Good catch, sorry for not hassle :)

0mp added a reviewer: yuripv.Apr 17 2021, 9:29 PM
0mp marked an inline comment as done.
yuripv accepted this revision.Apr 17 2021, 10:44 PM
This revision is now accepted and ready to land.Apr 17 2021, 10:44 PM
Closed by commit rG1ffdcdadf614: getprogname.3: Add an example (authored by 0mp). · Explain WhyApr 18 2021, 8:21 AM
This revision was automatically updated to reflect the committed changes.
0mp added a commit: rG1ffdcdadf614: getprogname.3: Add an example.
0mp added a commit: rG5cdee2441ed9: getprogname.3: Add an example.Aug 15 2021, 9:20 PM
0mp added a commit: rG2e34e54d4bf5: getprogname.3: Add an example.

Revision Contents
Changeset List

PathSize
lib/
libc/
gen/
28 lines

Diff 87644

View Options

lib/libc/gen/getprogname.3

Loading...