memset.c: Use unsigned long for stores
ClosedPublic
Actions

Authored by arichardson on Apr 1 2021, 2:38 PM.

Details

Reviewers

kib
brooks

Group Reviewers

riscv

Commits

rGfc19e3cb4fd1: libc/string/memset.c: Use unsigned long for stores
rGab147542b7c0: libc/string/memset.c: Use unsigned long for stores

Summary

While most 64-bit architectures have an assembly implementation of this
file, RISC-V does not. As we now store 8 bytes instead of 4 it should speed
up RISC-V.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 38253
Build 35142: arc lint + arc unit

Event Timeline

arichardson created this revision.Apr 1 2021, 2:38 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 1 2021, 2:38 PM

arichardson requested review of this revision.Apr 1 2021, 2:38 PM

Harbormaster completed remote builds in B38253: Diff 86693.Apr 1 2021, 2:38 PM

Would (u)intptr_t make more sense so it's faster on CHERI? Doesn't make a difference upstream but does to us.

In D29536#662074, @jrtc27 wrote:

Would (u)intptr_t make more sense so it's faster on CHERI? Doesn't make a difference upstream but does to us.

I thought about that, but that would require additional changes to create an all-ones capability register.

In D29536#662083, @arichardson wrote:

In D29536#662074, @jrtc27 wrote:

Would (u)intptr_t make more sense so it's faster on CHERI? Doesn't make a difference upstream but does to us.

I thought about that, but that would require additional changes to create an all-ones capability register.