align nfsdumpstate column output
ClosedPublic
Actions

Authored by yocalebo_gmail.com on Jan 25 2019, 5:30 PM.

Details

Reviewers

kithrup_mac.com
sef
freqlabs

Commits

rG57593b2bca76: align nfsdumpstate column output
rGb92b2ffd1233: align nfsdumpstate column output
rGefad9c8ba3ce: align nfsdumpstate column output

Summary

There are scenarios where an NFS client will mount an NFSv4 export without specifying a callback address.

When running nfsdumpstate under this circumstance, the column output is shifted incorrectly which places the "ClientID" value underneath the "Clientaddr" column.

This diff is a small cosmetic change that prints a blank in the "Clientaddr" column and ensures the data for the columns are aligned appropriately.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

yocalebo_gmail.com created this revision.Jan 25 2019, 5:30 PM

Hm, this will break the output. For the better, I think. Does it need a man page change as well?

I don't believe it will need a man page change because the dump_lockstate function already prints a blank for this column when a call back address isn't found.

Ok, seems good to me then.

This revision is now accepted and ready to land.Jan 25 2019, 5:41 PM

freqlabs accepted this revision.Mar 24 2021, 6:14 PM

This is still needed but the code has changed so the patch must be adapted.

This revision now requires changes to proceed.Mar 24 2021, 6:27 PM

yocalebo_gmail.com updated this revision to Diff 86265.Mar 24 2021, 6:54 PM

In D18958#658726, @freqlabs wrote:

This is still needed but the code has changed so the patch must be adapted.

Thanks, I've updated the diff accordingly.

freqlabs accepted this revision.Mar 24 2021, 6:57 PM

This revision is now accepted and ready to land.Mar 24 2021, 6:57 PM

yocalebo_gmail.com edited the summary of this revision. (Show Details)Mar 24 2021, 6:57 PM

freqlabs added inline comments.Mar 24 2021, 7:21 PM

usr.sbin/nfsdumpstate/nfsdumpstate.c
161	I missed this side of the diff when I first looked. It is fine to remove these lines, since inet_ntop can't fail in this case, however I might add an assert for that instead of the unbalanced if.