align nfsdumpstate column output

[yocalebo_gmail.com]

Summary

There are scenarios where an NFS client will mount an NFSv4 export without specifying a callback address.

When running nfsdumpstate under this circumstance, the column output is shifted incorrectly which places the "ClientID" value underneath the "Clientaddr" column.

This diff is a small cosmetic change that prints a blank in the "Clientaddr" column and ensures the data for the columns are aligned appropriately.

Sponsored by: iXsystems

[sef]

Hm, this will break the output. For the better, I think. Does it need a man page change as well?

[yocalebo_gmail.com]

I don't believe it will need a man page change because the dump_lockstate function already prints a blank for this column when a call back address isn't found.

[sef]

Ok, seems good to me then.

[freqlabs]

This is still needed but the code has changed so the patch must be adapted.

[yocalebo_gmail.com]

In D18958#658726, @freqlabs wrote:

This is still needed but the code has changed so the patch must be adapted.

Thanks, I've updated the diff accordingly.

[freqlabs]

usr.sbin/nfsdumpstate/nfsdumpstate.c

161

I missed this side of the diff when I first looked. It is fine to remove these lines, since inet_ntop can't fail in this case, however I might add an assert for that instead of the unbalanced if.

[yocalebo_gmail.com]

usr.sbin/nfsdumpstate/nfsdumpstate.c

161

You're right. I've updated the commit to keep the changes to specifically doing what my original commit was supposed to do.