Page MenuHomeFreeBSD
Differential D29216

pf: pool/kpool conversion code
ClosedPublic
Actions

Authored by kp on Mar 11 2021, 10:42 AM.
Tags
None
Referenced Files
F131555963: D29216.diff
Thu, Oct 9, 5:45 AM
Unknown Object (File)
Wed, Oct 8, 3:45 AM
Unknown Object (File)
Sun, Sep 21, 5:31 AM
Unknown Object (File)
Sep 9 2025, 4:26 AM
Unknown Object (File)
Jul 19 2025, 11:38 AM
Unknown Object (File)
Jul 5 2025, 7:43 PM
Unknown Object (File)
Jul 4 2025, 5:45 PM
Unknown Object (File)
Jun 26 2025, 8:57 AM
View All Files
Subscribers
farrokhi
imp
melifaro

Details

Reviewers
glebius
Group Reviewers
network
Commits
rG7d5886158650: pf: pool/kpool conversion code
rG961e7887b9ba: pf: pool/kpool conversion code
rG15b82e00a164: pf: pool/kpool conversion code
Summary

stuct pf_pool and struct pf_kpool are different. We should not simply
bcopy() them.

Happily it turns out that their differences were all pointers, and the
userspace provided pointers were overwritten by the kernel, so this did
actually work correctly, but we should fix it anyway.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
netpfil/
pf/
39 lines

Diff 85824

View Options

sys/netpfil/pf/pf_ioctl.c

Loading...