Page MenuHomeFreeBSD
Differential D28806

x86/iommu: Update following VM_ALLOC_ZERO semantic change
AbandonedPublic
Actions

Authored by markj on Feb 19 2021, 8:19 PM.
Tags
None
Referenced Files
F82989143: D28806.diff
Sat, May 4, 9:19 PM
Unknown Object (File)
Wed, May 1, 3:32 PM
Unknown Object (File)
Wed, May 1, 2:36 PM
Unknown Object (File)
Wed, May 1, 8:38 AM
Unknown Object (File)
Dec 20 2023, 7:00 AM
Unknown Object (File)
Dec 11 2023, 4:46 AM
Unknown Object (File)
Dec 6 2023, 2:11 AM
Unknown Object (File)
Sep 7 2023, 2:36 AM
View All 17 Files
Subscribers
alc
imp

Details

Reviewers
kib
Summary

This function is a bit special because it may return a resident page
without zeroing it, so I added an assertion and made this diff separate.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37203
Build 34092: arc lint + arc unit

Event Timeline

markj created this revision.Feb 19 2021, 8:19 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 19 2021, 8:19 PM
markj requested review of this revision.Feb 19 2021, 8:19 PM
markj added a parent revision: D28805: vm: Handle VM_ALLOC_ZERO in the page allocator.
Harbormaster completed remote builds in B37203: Diff 84294.Feb 19 2021, 8:19 PM
markj added a child revision: D28807: vm fault: Adapt to new VM_ALLOC_ZERO semantics.Feb 19 2021, 8:20 PM
markj added a reviewer: kib.Feb 19 2021, 8:26 PM
kib accepted this revision.Feb 19 2021, 9:15 PM
This revision is now accepted and ready to land.Feb 19 2021, 9:15 PM
alc added a subscriber: alc.Feb 20 2021, 7:01 PM
alc added inline comments.
sys/x86/iommu/intel_utils.c
274–275

Why not now move the locking outside the loop since we're no longer trying to perform the zeroing without the object lock being held? There would be two fewer lines of code, plus one more if unnecessary braces around the first unlock were eliminated.

markj abandoned this revision.Sep 16 2021, 2:47 PM

Revision Contents
Changeset List

PathSize
sys/
x86/
iommu/
16 lines

Diff 84294

View Options

sys/x86/iommu/intel_utils.c

Loading...