Page MenuHomeFreeBSD
Differential D28786

lib/msun: Avoid FE_INEXACT for x86 log2l/log10l
ClosedPublic
Actions

Authored by arichardson on Feb 19 2021, 12:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 30, 5:54 PM
Unknown Object (File)
Mon, Jan 19, 6:46 AM
Unknown Object (File)
Mon, Jan 19, 6:45 AM
Unknown Object (File)
Mon, Jan 19, 6:01 AM
Unknown Object (File)
Sun, Jan 18, 10:44 PM
Unknown Object (File)
Sun, Jan 18, 3:34 PM
Unknown Object (File)
Sun, Jan 18, 7:56 AM
Unknown Object (File)
Dec 26 2025, 5:44 PM
View All Files
Subscribers
imp

Details

Reviewers
dim
lwhsu
Commits
rGfe173c91b041: lib/msun: Avoid FE_INEXACT for x86 log2l/log10l
rG221622ec0c8e: lib/msun: Avoid FE_INEXACT for x86 log2l/log10l
Summary

This fixes tests/lib/msun/logarithm_test after compiling the test with
-fno-builtin (D28577). Adding invln10_lo + invln10_10 results in
FE_INEXACT and the same for the log2l invln2_lo + invln2_hi. This patch
avoids FE_INEXACT by defining a constant and using that.

Test Plan

logarithm_test works for me now.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37184
Build 34073: arc lint + arc unit

Event Timeline

arichardson created this revision.Feb 19 2021, 12:56 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 19 2021, 12:56 PM
arichardson requested review of this revision.Feb 19 2021, 12:56 PM
Harbormaster completed remote builds in B37184: Diff 84255.Feb 19 2021, 12:57 PM
arichardson mentioned this in D28798: Convert the msun tests to ATF.Feb 19 2021, 5:32 PM
arichardson updated this revision to Diff 84488.Feb 22 2021, 5:59 PM

Simpler approach

Harbormaster completed remote builds in B37280: Diff 84488.Feb 22 2021, 5:59 PM
arichardson edited the summary of this revision. (Show Details)Feb 22 2021, 6:00 PM
arichardson added a reviewer: lwhsu.
arichardson added a child revision: D28798: Convert the msun tests to ATF.
dim accepted this revision.Mar 5 2021, 8:48 PM

Although the original authors seem to dislike constant folding by the compiler, it is a good idea here. :)

This revision is now accepted and ready to land.Mar 5 2021, 8:48 PM
Closed by commit rG221622ec0c8e: lib/msun: Avoid FE_INEXACT for x86 log2l/log10l (authored by arichardson). · Explain WhyMar 8 2021, 9:44 AM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rG221622ec0c8e: lib/msun: Avoid FE_INEXACT for x86 log2l/log10l.
arichardson mentioned this in rG133bc645077d: Convert the msun tests to ATF.Mar 22 2021, 12:00 PM
arichardson added a commit: rGfe173c91b041: lib/msun: Avoid FE_INEXACT for x86 log2l/log10l.Apr 22 2021, 11:09 AM
arichardson mentioned this in rGb69904b8916c: Convert the msun tests to ATF.

Revision Contents
Changeset List

PathSize
lib/
msun/
ld80/
20 lines

Diff 84255

View Options

lib/msun/ld80/s_logl.c

Loading...