Handle partial data re-sending on ktls/sendfile on FreeBSD
ClosedPublic
Actions

Authored by jhb on Feb 16 2021, 6:58 PM.

Details

Reviewers

Commits

rG9b2f020c14af: Handle partial data re-sending on ktls/sendfile on FreeBSD

Summary

Add a handler for EBUSY sendfile error in addition to
EAGAIN. With EBUSY returned the data still can be partially
sent and user code has to be notified about it, otherwise it
may try to send data multiple times.

PR: 251969
Obtained from: OpenSSL (dfcfd17f2818cf520ce6381aed9ec3d2fc12170d)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 37065
Build 33954: arc lint + arc unit

Event Timeline

jhb created this revision.Feb 16 2021, 6:58 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 16 2021, 6:58 PM

jhb requested review of this revision.Feb 16 2021, 6:58 PM

Harbormaster completed remote builds in B37065: Diff 84032.Feb 16 2021, 6:58 PM

I've tested this on Netflix servers, and it seems to work.

It also reduces by about 50% the clients that close the connection for no reason, which sometimes indicate they got bad crypto data.

@jkim would you be able to commit a followup change to regenerate the relevant manual page after this lands?

In D28714#642840, @jhb wrote:

@jkim would you be able to commit a followup change to regenerate the relevant manual page after this lands?

Yes but I am working on importing OpenSSL 1.1.1j now.

In D28714#642846, @jkim wrote:

In D28714#642840, @jhb wrote:

@jkim would you be able to commit a followup change to regenerate the relevant manual page after this lands?

Yes but I am working on importing OpenSSL 1.1.1j now.