Page MenuHomeFreeBSD
Differential D28650

pf: Slightly relax pf_rule_addr validation
ClosedPublic
Actions

Authored by kp on Feb 13 2021, 4:33 PM.
Tags
None
Referenced Files
F144382491: D28650.id83872.diff
Sun, Feb 8, 4:07 AM
F144317297: D28650.id83835.diff
Sat, Feb 7, 7:47 PM
F144314453: D28650.id83848.diff
Sat, Feb 7, 7:29 PM
Unknown Object (File)
Fri, Jan 30, 7:11 PM
Unknown Object (File)
Dec 28 2025, 4:20 AM
Unknown Object (File)
Dec 11 2025, 4:21 PM
Unknown Object (File)
Nov 21 2025, 10:16 AM
Unknown Object (File)
Nov 18 2025, 1:16 AM
View All Files
Subscribers
donner
farrokhi
imp
melifaro

Details

Reviewers
donner
Group Reviewers
network
Commits
rG00abeecb4a25: pf: Slightly relax pf_rule_addr validation
rGf8d1f2da0922: pf: Slightly relax pf_rule_addr validation
rGf9a66bb91ae1: pf: Slightly relax pf_rule_addr validation
rG5e42cb139fc1: pf: Slightly relax pf_rule_addr validation
Summary

Ensure we don't reject no-route / urpf-failed addresses.

PR: 253479
MFC after: 3 days

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 36976
Build 33865: arc lint + arc unit

Event Timeline

kp created this revision.Feb 13 2021, 4:33 PM
Herald added subscribers: melifaro, farrokhi, imp. · View Herald TranscriptFeb 13 2021, 4:33 PM
kp requested review of this revision.Feb 13 2021, 4:33 PM
Harbormaster completed remote builds in B36971: Diff 83835.Feb 13 2021, 4:33 PM
donner added a subscriber: donner.Feb 13 2021, 7:52 PM
donner added inline comments.
sys/netpfil/pf/pf_ioctl.c
1564–1569

May give "switch () { case x: case y: ... " a try. It's easier to maintain and offers more flexibility for the compiler.

kp updated this revision to Diff 83848.Feb 13 2021, 8:26 PM

Use switch

Harbormaster completed remote builds in B36976: Diff 83848.Feb 13 2021, 8:27 PM
donner accepted this revision as: donner.Feb 14 2021, 11:16 AM
This revision is now accepted and ready to land.Feb 14 2021, 11:16 AM
Closed by commit rG5e42cb139fc1: pf: Slightly relax pf_rule_addr validation (authored by kp). · Explain WhyFeb 14 2021, 12:09 PM
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG5e42cb139fc1: pf: Slightly relax pf_rule_addr validation.
kp added a commit: rGf9a66bb91ae1: pf: Slightly relax pf_rule_addr validation.Feb 17 2021, 1:05 PM
kp added a commit: rGf8d1f2da0922: pf: Slightly relax pf_rule_addr validation.
kp added a commit: rG00abeecb4a25: pf: Slightly relax pf_rule_addr validation.Feb 17 2021, 4:50 PM

Revision Contents
Changeset List

PathSize
sys/
netpfil/
pf/
47 lines

Diff 83848

View Options

sys/netpfil/pf/pf_ioctl.c

Loading...