lualoader: handle local module errors more gracefully
Needs ReviewPublic
Actions

Authored by kevans on Feb 12 2021, 10:40 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Aug 19, 9:36 AM

	Unknown Object (File)
	Mon, Aug 17, 3:25 AM

	Unknown Object (File)
	Sat, Aug 15, 3:49 PM

	Unknown Object (File)
	Wed, Aug 12, 5:53 PM

	Unknown Object (File)
	Sun, Aug 9, 12:09 AM

	Unknown Object (File)
	Sat, Aug 8, 9:24 PM

	Unknown Object (File)
	Fri, Aug 7, 11:33 AM

	Unknown Object (File)
	Sat, Aug 1, 8:39 AM

View All Files

Subscribers

None

Details

Reviewers

glebius
imp
rpokala
andrew_tao173.riddles.org.uk

Summary

Load the module and call it in protected mode so that we can bubble
up errors rather than breaking the system further.

Note that we cannot make any guarantees about the state of the
environment if an error occurred; changes may have still been partially
applied depending on the shape/size/position of the error.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 36947
Build 33836: arc lint + arc unit

Event Timeline

kevans requested review of this revision.Feb 12 2021, 10:40 PM

kevans created this revision.

Harbormaster completed remote builds in B36947: Diff 83794.Feb 12 2021, 10:40 PM

kevans added a reviewer: andrew_tao173.riddles.org.uk.Feb 12 2021, 10:40 PM

pcall(loadfile(...)) -> pcall(dofile, ...) to return a more useful error if
chunk loading happens to fail.

Harbormaster completed remote builds in B36948: Diff 83795.Feb 12 2021, 10:48 PM

Looks basically sane to me.

Revision Contents
Changeset List

Path

Size

stand/

lua/

core.lua

26 lines

loader.lua

8 lines

Diff 83794

View Options

stand/lua/core.lua