Differential D28555

vm: Honour the "noreuse" flag to vm_page_unwire_managed()
ClosedPublic
Actions

Authored by markj on Feb 9 2021, 4:27 PM.

Tags

None

Referenced Files

	F106044334: D28555.diff
	Tue, Dec 24, 10:01 AM

	Unknown Object (File)
	Fri, Dec 20, 6:30 PM

	Unknown Object (File)
	Fri, Dec 20, 1:08 PM

	Unknown Object (File)
	Nov 18 2024, 12:25 PM

	Unknown Object (File)
	Nov 18 2024, 10:24 AM

	Unknown Object (File)
	Nov 17 2024, 3:06 AM

	Unknown Object (File)
	Nov 17 2024, 12:56 AM

	Unknown Object (File)
	Nov 10 2024, 8:58 PM

View All 46 Files

Subscribers

Details

Reviewers

alc
kib
dougm

Commits

rG678abec026af: vm: Honour the "noreuse" flag to vm_page_unwire_managed()
rGa73aaaeb579b: vm: Honour the "noreuse" flag to vm_page_unwire_managed()
rG5c18744ea9b9: vm: Honour the "noreuse" flag to vm_page_unwire_managed()

Summary

This flag indicates that the page should be enqueued near the head of
the inactive queue, skipping the LRU queue. It is used when unwiring
pages from the buffer cache following direct I/O or after I/O when
POSIX_FADV_NOREUSE or _DONTNEED advice was specified, or when
sendfile(SF_NOCACHE) completes. For the direct I/O and sendfile cases
we only enqueue the page if we decide not to free it, typically because
it's mapped.

Pass "noreuse" through to vm_page_release_toq() so that we actually
honour the desired LRU policy.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Feb 9 2021, 4:27 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 9 2021, 4:27 PM

markj requested review of this revision.Feb 9 2021, 4:27 PM

Harbormaster completed remote builds in B36831: Diff 83594.Feb 9 2021, 4:27 PM

markj added reviewers: alc, kib, dougm.Feb 9 2021, 4:27 PM

kib accepted this revision.Feb 9 2021, 5:08 PM

This revision is now accepted and ready to land.Feb 9 2021, 5:08 PM

alc accepted this revision.Feb 9 2021, 5:40 PM

Closed by commit rG5c18744ea9b9: vm: Honour the "noreuse" flag to vm_page_unwire_managed() (authored by markj). · Explain WhyFeb 10 2021, 4:10 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG5c18744ea9b9: vm: Honour the "noreuse" flag to vm_page_unwire_managed().

markj added a commit: rGa73aaaeb579b: vm: Honour the "noreuse" flag to vm_page_unwire_managed().Feb 13 2021, 12:26 AM

markj added a commit: rG678abec026af: vm: Honour the "noreuse" flag to vm_page_unwire_managed().Feb 13 2021, 1:31 AM

Revision Contents
Changeset List

Path

Size

sys/

vm/

2 lines

Diff 83646

sys/vm/vm_page.c

Loading...