Page MenuHomeFreeBSD
Differential D28478

lib/libc/tests/rpc: Correctly set timeout
ClosedPublic
Actions

Authored by arichardson on Feb 4 2021, 12:54 PM.
Tags
None
Referenced Files
F103439144: D28478.id83358.diff
Mon, Nov 25, 1:19 AM
Unknown Object (File)
Fri, Nov 22, 12:59 PM
Unknown Object (File)
Fri, Nov 22, 7:12 AM
Unknown Object (File)
Sun, Nov 17, 8:57 PM
Unknown Object (File)
Sun, Nov 17, 5:32 PM
Unknown Object (File)
Sun, Nov 10, 11:21 PM
Unknown Object (File)
Sun, Nov 10, 8:51 PM
Unknown Object (File)
Sun, Nov 10, 8:04 PM
View All Files
Subscribers
imp

Details

Reviewers
lwhsu
ngie
Commits
rGb40b1ae9d59d: lib/libc/tests/rpc: Correctly set timeout
rG90b5fc95832d: lib/libc/tests/rpc: Correctly set timeout
Summary

The rpc_control() API does not accept the CLCR_SET_RPCB_TIMEOUT command,
it only accepts RPC_SVC_CONNMAXREC_GET/RPC_SVC_CONNMAXREC_SET, so it was
not doing anything.
Instead of incorrectly calling this API, use clnt_create_timed() instead.

I noticed this because the test was timing out after 120s in the CheriBSD CI.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 36705
Build 33594: arc lint + arc unit

Event Timeline

arichardson created this revision.Feb 4 2021, 12:54 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 4 2021, 12:54 PM
arichardson requested review of this revision.Feb 4 2021, 12:54 PM
Harbormaster completed remote builds in B36698: Diff 83343.Feb 4 2021, 12:54 PM
ngie requested changes to this revision.Feb 4 2021, 4:31 PM

Could you please wrap the changes in #ifdef __FreeBSD__ so it'd be easier for me to upstream to NetBSD?

This revision now requires changes to proceed.Feb 4 2021, 4:31 PM
arichardson updated this revision to Diff 83358.Feb 4 2021, 4:47 PM

Add #ifdef for easier upstreaming

Harbormaster completed remote builds in B36704: Diff 83358.Feb 4 2021, 4:48 PM
arichardson updated this revision to Diff 83359.Feb 4 2021, 4:48 PM

reduce diff

Harbormaster completed remote builds in B36705: Diff 83359.Feb 4 2021, 4:49 PM
arichardson updated this revision to Diff 83360.Feb 4 2021, 5:06 PM

Upload correct diff

Harbormaster completed remote builds in B36706: Diff 83360.Feb 4 2021, 5:07 PM
arichardson added a comment.Feb 12 2021, 5:36 PM

ping.

ngie accepted this revision.Feb 12 2021, 6:45 PM

Macro goatforit:

This revision is now accepted and ready to land.Feb 12 2021, 6:45 PM
Closed by commit rG90b5fc95832d: lib/libc/tests/rpc: Correctly set timeout (authored by arichardson). · Explain WhyFeb 13 2021, 2:13 PM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rG90b5fc95832d: lib/libc/tests/rpc: Correctly set timeout.
arichardson added a commit: rGb40b1ae9d59d: lib/libc/tests/rpc: Correctly set timeout.Mar 17 2021, 10:30 AM

Revision Contents
Changeset List

PathSize
contrib/
netbsd-tests/
lib/
libc/
rpc/
14 lines

Diff 83359

View Options

contrib/netbsd-tests/lib/libc/rpc/t_rpc.c

Loading...