Page MenuHomeFreeBSD

lib/libc/tests/rpc: Correctly set timeout
ClosedPublic

Authored by arichardson on Feb 4 2021, 12:54 PM.

Details

Summary

The rpc_control() API does not accept the CLCR_SET_RPCB_TIMEOUT command,
it only accepts RPC_SVC_CONNMAXREC_GET/RPC_SVC_CONNMAXREC_SET, so it was
not doing anything.
Instead of incorrectly calling this API, use clnt_create_timed() instead.

I noticed this because the test was timing out after 120s in the CheriBSD CI.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 36705
Build 33594: arc lint + arc unit

Event Timeline

ngie requested changes to this revision.Feb 4 2021, 4:31 PM

Could you please wrap the changes in #ifdef __FreeBSD__ so it'd be easier for me to upstream to NetBSD?

This revision now requires changes to proceed.Feb 4 2021, 4:31 PM

Add #ifdef for easier upstreaming

This revision is now accepted and ready to land.Feb 12 2021, 6:45 PM