Remove redundantcy from the arm GIC softc
ClosedPublic
Actions

Authored by andrew on Jan 25 2021, 8:14 PM.

Details

Reviewers

Group Reviewers

ARM
arm64

Commits

rGdd6c1c2a6c0d: Remove redundantcy from the arm GIC softc

Summary

A struct recource already contains the bus_space_tag_t and
bus_space_handle_t. There is no neec to read them and store them again
in the drivers softc. Remove them and use the struct resource directly
with bus_read_* and bus_write_*.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 36479
Build 33368: arc lint + arc unit

Event Timeline

andrew created this revision.Jan 25 2021, 8:14 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 25 2021, 8:14 PM

andrew requested review of this revision.Jan 25 2021, 8:14 PM

Harbormaster completed remote builds in B36479: Diff 82874.Jan 25 2021, 8:14 PM

LGTM

This revision is now accepted and ready to land.Jan 27 2021, 10:43 AM

Closed by commit rGdd6c1c2a6c0d: Remove redundantcy from the arm GIC softc (authored by andrew). · Explain WhyJan 27 2021, 7:10 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rGdd6c1c2a6c0d: Remove redundantcy from the arm GIC softc.

Revision Contents
Changeset List

Path

Size

sys/

arm/

gic.h

6 lines

gic.c

19 lines

Diff 82874

View Options

sys/arm/arm/gic.h

This file was added.

				# Created by: Jonathan Anderson <jonathan@FreeBSD.org>
				# $FreeBSD$

				PORTNAME= git-cola
				PORTVERSION= 2.2.1
				DISTVERSIONPREFIX= v
				CATEGORIES= devel

				MAINTAINER= ports@FreeBSD.org
				COMMENT= Sleek and powerful Git GUI
				pgollucciUnsubmitted Done Inline Actions mainter should be ports@ or yourself pgollucci: mainter should be ports@ or yourself

				brooksUnsubmitted Done Inline Actions MAINTAINER should be submitter. We shouldn't commit pre-orphaned ports. brooks: MAINTAINER should be submitter. We shouldn't commit pre-orphaned ports.
				LICENSE= GPLv2

				USE_GITHUB= yes

				USES= desktop-file-utils gettext gmake python
				INSTALLS_ICONS= YES
				brdUnsubmitted Done Inline Actions GH_ACCOUNT & GH_PROJECT can both be removed since they default to the value of ${PORTNAME}: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#makefile-master_sites-github-description brd: GH_ACCOUNT & GH_PROJECT can both be removed since they default to the value of ${PORTNAME}…

				MAKE_FLAGS= "prefix=${PREFIX}"

				.include <bsd.port.mk>