New port: x11/sprop
ClosedPublic
Actions

Authored by kfv_kfv.io on Jan 15 2021, 7:37 AM.

Details

Reviewers

lwhsu
ygy

Commits

rP562110: new port: x11/sprop: Simple X property utility

Summary

New port: x11/sprop - a simple X property utility

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 36218
Build 33107: arc lint + arc unit

Event Timeline

kfv_kfv.io created this revision.Jan 15 2021, 7:37 AM

Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptJan 15 2021, 7:37 AM

kfv_kfv.io requested review of this revision.Jan 15 2021, 7:37 AM

Harbormaster completed remote builds in B36216: Diff 82301.Jan 15 2021, 7:38 AM

lwhsu requested changes to this revision.Jan 15 2021, 7:46 AM

lwhsu added a subscriber: lwhsu.

lwhsu added inline comments.

x11/sprop/Makefile
4	A new port doesn't need `PORTREVISION`
9	I suggest use use "Simple X property utility"
x11/sprop/pkg-descr
6	This link returns 404.

This revision now requires changes to proceed.Jan 15 2021, 7:46 AM

Please refer (but not blindly follow) the suggestions from portlint and portfmt tools. The suggested Makefile is like:

# $FreeBSD$

PORTNAME=       sprop
PORTVERSION=    0.1
PORTREVISION=   1
CATEGORIES=     x11
MASTER_SITES=   http://dl.suckless.org/tools/

MAINTAINER=     kfv@kfv.io
COMMENT=        Simple X property utility

LICENSE=        MIT
LICENSE_FILE=   ${WRKSRC}/LICENSE

USES=           xorg
USE_XORG=       x11

MAKE_ARGS=      PREFIX="${PREFIX}" X11LIB="${LOCALBASE}/lib" \
                X11INC="${LOCALBASE}/include" CC="${CC}"
PLIST_FILES=    bin/${PORTNAME} \
                share/man/man1/${PORTNAME}.1.gz

.include <bsd.port.mk>

x11/sprop/pkg-descr
4	It's better to have a more descriptive description.

Sorry for my mistakes, I will be more careful and use the mentioned tools next
time. I also fixed the link in the description and made it a bit more descriptive
by adding some information from the manual and the author's official announcement.

Harbormaster completed remote builds in B36217: Diff 82302.Jan 15 2021, 8:28 AM

lwhsu accepted this revision.Jan 15 2021, 8:33 AM

lwhsu added inline comments.

x11/sprop/pkg-descr
9	The site supports HTTPS: https://tools.suckless.org/x/sprop/

This revision is now accepted and ready to land.Jan 15 2021, 8:33 AM

I just updated the link in the description.

This revision now requires review to proceed.Jan 15 2021, 8:39 AM

Harbormaster completed remote builds in B36218: Diff 82303.Jan 15 2021, 8:39 AM

lwhsu accepted this revision.Jan 15 2021, 9:04 AM

This revision is now accepted and ready to land.Jan 15 2021, 9:04 AM

Looks good to me, though I think we should switch to use https if it is available.

x11/sprop/Makefile
6	I believe https is also available for this site :)

I updated the link in the pkg-descr file but left the MASTER_SITES as is to be similar to other suckless ports. If you think it's necessary to update all HTTP links to HTTPS when supported (just like those from suckless), I can do a bulk check and submit a patch for that since we've also got many HTTPS MASTER_SITES in ports - or we can avoid forcing HTTPS and leave its decision to master sites. Anyway, I'll follow as you decide.

@kfv_irbug.org I committed the port with the minor change of http => https. Thanks again!

Closed by commit rP562110: new port: x11/sprop: Simple X property utility (authored by ygy). · Explain WhyJan 20 2021, 8:54 AM

This revision was automatically updated to reflect the committed changes.

ygy added a commit: rP562110: new port: x11/sprop: Simple X property utility.