hid: quiet -Wswitch
ClosedPublic
Actions

Authored by rlibby on Jan 10 2021, 7:59 AM.

Details

Reviewers

• hselasky
wulf

Commits

rG16079c7233be: hid: quiet -Wswitch

Summary

Gcc builds complained that not all switch cases are handled. Add empty
cases to appease gcc.

Please feel free to take this over and solve in any way you see fit. I
have just posted this review for expediency in case this is your
preferred approach.

Also, I am not sure whether this code has an upstream. Please advise if
so.

Test Plan

env MAKEOBJDIRPREFIX=/usr/obj/gcc9 CROSS_TOOLCHAIN=amd64-gcc9 make buildkernel

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 36084
Build 32973: arc lint + arc unit

Event Timeline

rlibby created this revision.Jan 10 2021, 7:59 AM

Herald added a subscriber: imp. · View Herald TranscriptJan 10 2021, 7:59 AM

rlibby requested review of this revision.Jan 10 2021, 7:59 AM

Harbormaster completed remote builds in B36084: Diff 82016.Jan 10 2021, 7:59 AM

LGTM

This revision is now accepted and ready to land.Jan 10 2021, 9:37 AM

Why not just add default: ? Anyways looks good.

In D28082#627465, @hselasky wrote:

Why not just add default: ? Anyways looks good.

Yes. default: looks better.

The advantage of listing cases instead of using default would be that if another enum value ever gets added, then the compiler's warning about unhandled cases won't have been suppressed. But I agree it's uglier. I'll change it to default.

Feedback: use default instead of listing cases

This revision now requires review to proceed.Jan 10 2021, 7:57 PM

Harbormaster completed remote builds in B36092: Diff 82040.Jan 10 2021, 7:58 PM

wulf accepted this revision.Jan 10 2021, 9:29 PM

This revision is now accepted and ready to land.Jan 10 2021, 9:29 PM

Closed by commit rG16079c7233be: hid: quiet -Wswitch (authored by rlibby). · Explain WhyJan 11 2021, 5:56 AM

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rG16079c7233be: hid: quiet -Wswitch.