Page MenuHomeFreeBSD
Differential D25160

ufs: add O_DSYNC support
ClosedPublic
Actions

Authored by tmunro on Jun 5 2020, 10:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 8 2024, 7:41 PM
Unknown Object (File)
Dec 20 2023, 6:06 AM
Unknown Object (File)
Dec 10 2023, 10:18 PM
Unknown Object (File)
Oct 20 2023, 11:19 AM
Unknown Object (File)
Oct 10 2023, 7:53 PM
Unknown Object (File)
Sep 17 2023, 12:22 PM
Unknown Object (File)
Sep 6 2023, 9:50 AM
Unknown Object (File)
Sep 2 2023, 4:04 PM
View All 24 Files
Subscribers
None

Details

Reviewers
kib
mjg
mckusick
Summary

Building on top of D25090, here is a patch to teach UFS to understand O_DSYNC.

Test Plan

Using a test program at https://github.com/macdice/some-io-tests/blob/master/sync.c and watching IO with dwatch -X io, we can verify that O_DSYNC updates the inode only when fdatasync would (eg for size change, but not for overwrite).

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

tmunro requested review of this revision.Jun 5 2020, 10:15 PM
tmunro created this revision.
kib added a comment.Jun 23 2020, 4:14 AM

I am not sure what you see in dtrace, but I see a bug in ffs_write() regardless of IO_DATASYNC. D25404

tmunro updated this revision to Diff 81741.Jan 6 2021, 11:47 AM
tmunro edited the summary of this revision. (Show Details)
tmunro edited the test plan for this revision. (Show Details)

Rebased. Previous confusion turned out to be explained by problems fixed by D27353 and problems in my test methodology.

tmunro mentioned this in D25071: aio_fsync(O_DSYNC).Jan 6 2021, 11:49 AM
kib added a reviewer: mckusick.Jan 6 2021, 1:36 PM
kib accepted this revision.Jan 6 2021, 1:44 PM
This revision is now accepted and ready to land.Jan 6 2021, 1:44 PM
tmunro mentioned this in rGe7347be9e34d: ffs: Support O_DSYNC..Jan 8 2021, 12:17 AM
tmunro closed this revision.Jan 9 2021, 7:34 PM

Revision Contents
Changeset List

PathSize
sys/
ufs/
ffs/
4 lines

Diff 81741

View Options

sys/ufs/ffs/ffs_vnops.c

Loading...