Page MenuHomeFreeBSD

rtld: When relocating, map without PROT_EXEC
ClosedPublic

Authored by emaste on Jan 4 2021, 5:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 12 2024, 10:48 PM
Unknown Object (File)
Feb 6 2024, 1:32 AM
Unknown Object (File)
Feb 1 2024, 10:51 PM
Unknown Object (File)
Jan 27 2024, 9:40 PM
Unknown Object (File)
Dec 20 2023, 5:39 AM
Unknown Object (File)
Dec 20 2023, 5:39 AM
Unknown Object (File)
Dec 11 2023, 2:45 AM
Unknown Object (File)
Nov 4 2023, 11:28 AM
Subscribers

Details

Summary

This makes text segment relocation work under W^X.


I have encountered this when loading lucet-compiled shared objects with W^X (D24933).

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

libexec/rtld-elf/rtld.c
2986–2987

maybe clearer if we incorporate the PROT_WRITE part from above?

something like

prot = convert_prot(ph->p_flags);
if (before)
        prot = prot & ~PROT_EXEC | PROT_WRITE;
libexec/rtld-elf/rtld.c
2986–2987

There is no much reason to use convert_prot() in'before' case at all, then. Only PF_R survives. It can be

prot = before ? (PROT_READ | PROT_WRITE) : convert_prot(ph->p_flags);
emaste updated this revision to Diff 81672.
emaste edited reviewers, added: val_packett.cool; removed: emaste.

Update per kib's suggestion

This revision is now accepted and ready to land.Jan 5 2021, 3:04 PM
This revision was automatically updated to reflect the committed changes.