Honor the PG_NODUMP flag in is_dumpable() on arm and i386
ClosedPublic
Actions

Authored by alc on Jan 4 2021, 7:34 AM.

Tags

None

Referenced Files

	F171583371: D27949.id81606.diff
	Fri, Sep 11, 10:03 PM

	F171582866: D27949.id81651.diff
	Fri, Sep 11, 9:57 PM

	F171582505: D27949.diff
	Fri, Sep 11, 9:54 PM

	Unknown Object (File)
	Tue, Sep 8, 2:27 PM

	Unknown Object (File)
	Sun, Sep 6, 6:13 AM

	Unknown Object (File)
	Sun, Sep 6, 5:18 AM

	Unknown Object (File)
	Sun, Sep 6, 3:06 AM

	Unknown Object (File)
	Sat, Sep 5, 1:19 PM

View All Files

Subscribers

andrew

Details

Reviewers

kib
markj

Commits

rG7beeacb27b27: Honor the vm page's PG_NODUMP flag on arm and i386.

Summary

The arm and i386 implementations of is_dumpable() are the only implementations that don't check the PG_NODUMP flag. Add the check to the arm and i386 implementations.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

alc created this revision.Jan 4 2021, 7:34 AM

Herald added a subscriber: andrew. · View Herald TranscriptJan 4 2021, 7:34 AM

alc requested review of this revision.Jan 4 2021, 7:34 AM

kib accepted this revision.Jan 4 2021, 8:48 AM

This revision is now accepted and ready to land.Jan 4 2021, 8:48 AM

markj accepted this revision.Jan 4 2021, 1:15 PM

Closed by commit rG7beeacb27b27: Honor the vm page's PG_NODUMP flag on arm and i386. (authored by alc). · Explain WhyJan 4 2021, 10:17 PM

This revision was automatically updated to reflect the committed changes.

alc added a commit: rG7beeacb27b27: Honor the vm page's PG_NODUMP flag on arm and i386..

Revision Contents
Changeset List

Path

Size

sys/

arm/

minidump_machdep.c

3 lines

i386/

minidump_machdep_base.c

3 lines

Diff 81651

View Options

sys/arm/arm/minidump_machdep.c