Honor the PG_NODUMP flag in is_dumpable() on arm and i386
ClosedPublic
Actions

Authored by alc on Jan 4 2021, 7:34 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 21, 6:32 AM

	Unknown Object (File)
	Thu, Nov 14, 9:27 PM

	Unknown Object (File)
	Sep 25 2024, 1:36 PM

	Unknown Object (File)
	Sep 24 2024, 6:01 AM

	Unknown Object (File)
	Sep 23 2024, 2:25 AM

	Unknown Object (File)
	Sep 22 2024, 7:44 AM

	Unknown Object (File)
	Sep 20 2024, 5:44 AM

	Unknown Object (File)
	Sep 1 2024, 10:02 PM

View All 38 Files

Subscribers

andrew

Details

Reviewers

kib
markj

Commits

rG7beeacb27b27: Honor the vm page's PG_NODUMP flag on arm and i386.

Summary

The arm and i386 implementations of is_dumpable() are the only implementations that don't check the PG_NODUMP flag. Add the check to the arm and i386 implementations.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

alc created this revision.Jan 4 2021, 7:34 AM

Herald added a subscriber: andrew. · View Herald TranscriptJan 4 2021, 7:34 AM

alc requested review of this revision.Jan 4 2021, 7:34 AM

kib accepted this revision.Jan 4 2021, 8:48 AM

This revision is now accepted and ready to land.Jan 4 2021, 8:48 AM

markj accepted this revision.Jan 4 2021, 1:15 PM

Closed by commit rG7beeacb27b27: Honor the vm page's PG_NODUMP flag on arm and i386. (authored by alc). · Explain WhyJan 4 2021, 10:17 PM

This revision was automatically updated to reflect the committed changes.

alc added a commit: rG7beeacb27b27: Honor the vm page's PG_NODUMP flag on arm and i386..

Revision Contents
Changeset List

Path

Size

sys/

arm/

minidump_machdep.c

3 lines

i386/

minidump_machdep_base.c

3 lines

Diff 81606

View Options

sys/arm/arm/minidump_machdep.c