[vale] Fix valectl to compile on a 32-bit platform
ClosedPublic
Actions

Authored by adrian on Dec 29 2020, 6:26 PM.

Details

Reviewers

vmaffione
rlibby

Commits

rG697684325da8: [vale] Fix valectl to compile on a 32-bit platform

Summary

This shows up when compiling valectl on a 32 bit platform like i386 and mips32.
gcc-6.4 complains about this.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35751
Build 32640: arc lint + arc unit

Event Timeline

adrian created this revision.Dec 29 2020, 6:26 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 29 2020, 6:26 PM

adrian requested review of this revision.Dec 29 2020, 6:26 PM

Harbormaster completed remote builds in B35751: Diff 81317.Dec 29 2020, 6:26 PM

adrian added a reviewer: vmaffione.Dec 29 2020, 6:27 PM

LGTM
Thanks!

This revision is now accepted and ready to land.Dec 29 2020, 8:58 PM

ryan - I'll push this later today, but i figured you would want to see it as well :-)

LGTM. The same construct is seen in other assignments to pointers from nr_body.

I recommend putting the name of the warning you're solving in the commit log somewhere (-Wint-to-pointer-cast, right?).

The i386 kernel has a lot more of these due to PAE, but I haven't dug in to those.

Closed by commit rG697684325da8: [vale] Fix valectl to compile on a 32-bit platform (authored by adrian). · Explain WhyDec 30 2020, 6:44 PM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG697684325da8: [vale] Fix valectl to compile on a 32-bit platform.

Revision Contents
Changeset List

Path

Size

usr.sbin/

valectl/

valectl.c

2 lines

Diff 81317

View Options

usr.sbin/valectl/valectl.c

[vale] Fix valectl to compile on a 32-bit platformClosedPublicActions