Add a check to preload_search_info to make sure mod is correctly set. Most
of the callers of preload_search_info don't check that the mod parameter is
valid, which can cause page faults.
Sponsored by: Citrix Systems R&D
Details
Details
- Reviewers
kib jhb - Commits
- rS287000: preload_search_info: make sure mod is set
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 174 Build 174: arc lint + arc unit
Event Timeline
Comment Actions
I would argue that the commit message should talk not about the 'correct' kmdp, but instead of kmdp presence.
There is at least one place which is now redundandly check for kmdp != NULL, look at the hammer_time():1624.
Comment Actions
Thanks, I've updated the commit message and removed some unnecessary kmdp !=
NULL checks before calling preload_search_info and MD_FETCH.
Currently running a tinderbox, will commit after tinderbox finishes unless
there are other comments.