Page MenuHomeFreeBSD
Differential D27675

Use more light-weight versions of routing lookup functions in ng_netflow.
ClosedPublic
Actions

Authored by melifaro on Dec 18 2020, 8:57 PM.
Tags
None
Referenced Files
F144438646: D27675.id81185.diff
Sun, Feb 8, 11:02 AM
F144346395: D27675.id80918.diff
Sat, Feb 7, 11:27 PM
F144326518: D27675.id80919.diff
Sat, Feb 7, 9:03 PM
Unknown Object (File)
Sat, Feb 7, 5:12 PM
Unknown Object (File)
Sat, Jan 31, 2:41 PM
Unknown Object (File)
Dec 14 2025, 7:18 AM
Unknown Object (File)
Dec 2 2025, 9:53 AM
Unknown Object (File)
Dec 2 2025, 6:17 AM
View All Files
Subscribers
ae
donner
imp

Details

Reviewers
None
Group Reviewers
network
Commits
rG4e19e0d92ac6: Use light-weight versions of routing lookup functions in ng_netflow.
Summary

Use recently-added combination of fib[46]_lookup_rt() which returns rtentry & raw nexthop with
rt_get_inet[6]_plen() which returns address/prefix length of prefix inside rt instead of rib_lookup_info().

New calls does not require reference counting objects and reduce the amount of copied/processed rtentry data.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 35525
Build 32426: arc lint + arc unit

Event Timeline

melifaro created this revision.Dec 18 2020, 8:57 PM
Herald added subscribers: donner, imp. · View Herald TranscriptDec 18 2020, 8:57 PM
Harbormaster completed remote builds in B35523: Diff 80916.Dec 18 2020, 8:57 PM
melifaro requested review of this revision.Dec 18 2020, 8:57 PM
melifaro updated this revision to Diff 80918.Dec 18 2020, 9:05 PM

Add nhop_select_func().

Herald added a subscriber: ae. · View Herald TranscriptDec 18 2020, 9:05 PM
Harbormaster completed remote builds in B35525: Diff 80918.Dec 18 2020, 9:06 PM
melifaro edited the summary of this revision. (Show Details)Dec 18 2020, 9:08 PM
melifaro added a reviewer: network.
melifaro updated this revision to Diff 80919.Dec 18 2020, 9:09 PM

.

Harbormaster completed remote builds in B35526: Diff 80919.Dec 18 2020, 9:10 PM
donner added a comment.Dec 18 2020, 9:23 PM

Excellent example how to apply the new API.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 26 2020, 11:33 AM
Closed by commit rG4e19e0d92ac6: Use light-weight versions of routing lookup functions in ng_netflow. (authored by melifaro). · Explain Why
This revision was automatically updated to reflect the committed changes.
melifaro added a commit: rG4e19e0d92ac6: Use light-weight versions of routing lookup functions in ng_netflow..

Revision Contents
Changeset List

PathSize
sys/
net/
route/
1 line
7 lines
18 lines
8 lines
netgraph/
netflow/
145 lines

Diff 80918

View Options

sys/net/route/nhop.h

Loading...
View Options

sys/net/route/nhop_ctl.c

Loading...
View Options

sys/net/route/route_tables.c

Loading...
View Options

sys/net/route/route_var.h

Loading...
View Options

sys/netgraph/netflow/netflow.c

Loading...