Page MenuHomeFreeBSD
Differential D27093

VFS_QUOTACTL: Remove needless casts of arg argument
ClosedPublic
Actions

Authored by brooks on Nov 4 2020, 10:01 PM.
Tags
None
Referenced Files
F144471473: D27093.id79187.diff
Sun, Feb 8, 3:08 PM
Unknown Object (File)
Sat, Jan 31, 7:37 AM
Unknown Object (File)
Jan 1 2026, 11:20 PM
Unknown Object (File)
Dec 31 2025, 12:32 AM
Unknown Object (File)
Nov 28 2025, 12:49 PM
Unknown Object (File)
Nov 28 2025, 7:57 AM
Unknown Object (File)
Nov 27 2025, 6:59 PM
Unknown Object (File)
Nov 20 2025, 11:24 PM
View All Files
Subscribers
imp

Details

Reviewers
rmacklem
freqlabs
Group Reviewers
manpages
Commits
rG2a0be7b0331c: VFS_QUOTACTL: Remove needless casts of arg
rS368744: VFS_QUOTACTL: Remove needless casts of arg
Summary

The argument is a void * so there's no need to cast it to caddr_t.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks created this revision.Nov 4 2020, 10:01 PM
Harbormaster completed remote builds in B34631: Diff 79187.Nov 4 2020, 10:01 PM
brooks requested review of this revision.Nov 4 2020, 10:01 PM
freqlabs accepted this revision.Nov 4 2020, 10:29 PM

VFS_QUOTACTL(9) shows it as caddr_t, so I suppose that needs to be fixed as well.

This revision is now accepted and ready to land.Nov 4 2020, 10:29 PM
brooks updated this revision to Diff 79276.Nov 6 2020, 6:15 PM
  • VFS_QUOTACTL(9): correct type of arg
This revision now requires review to proceed.Nov 6 2020, 6:15 PM
Harbormaster completed remote builds in B34673: Diff 79276.Nov 6 2020, 6:15 PM
freqlabs accepted this revision.Dec 17 2020, 9:51 PM
This revision is now accepted and ready to land.Dec 17 2020, 9:51 PM
Closed by commit rS368744: VFS_QUOTACTL: Remove needless casts of arg (authored by brooks). · Explain WhyDec 17 2020, 9:58 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rS368744: VFS_QUOTACTL: Remove needless casts of arg.
Herald added a reviewer: manpages. · View Herald TranscriptDec 17 2020, 9:58 PM
Herald added a subscriber: imp. · View Herald Transcript
brooks added a commit: rG2a0be7b0331c: VFS_QUOTACTL: Remove needless casts of arg.Jan 25 2021, 10:17 PM

Revision Contents
Changeset List

PathSize
head/
share/
man/
man9/
4 lines
sys/
fs/
nfs/
14 lines

Diff 80869

View Options

head/share/man/man9/VFS_QUOTACTL.9

Loading...
View Options

head/sys/fs/nfs/nfs_commonsubs.c

Loading...