Page MenuHomeFreeBSD

pf: Fix table entry counter toggling
ClosedPublic

Authored by markj on Dec 1 2020, 6:39 PM.
Tags
None
Referenced Files
F154886094: D27440.id80203.diff
Wed, Apr 29, 7:01 PM
F154784568: D27440.id80203.diff
Wed, Apr 29, 10:57 AM
Unknown Object (File)
Wed, Apr 29, 3:41 AM
Unknown Object (File)
Mon, Apr 27, 9:21 PM
Unknown Object (File)
Tue, Apr 21, 11:01 AM
Unknown Object (File)
Tue, Apr 14, 8:57 AM
Unknown Object (File)
Tue, Apr 14, 2:15 AM
Unknown Object (File)
Mon, Apr 13, 5:08 AM

Details

Summary

When updating a table, pf will keep table entry structures corresponding
to addresses that are in both of the old and new tables. However, the
update may also enable or disable per-entry counters which are allocated
separately. Thus when toggling PFR_TFLAG_COUNTERS, the entries may be
missing counters or may have unused counters allocated.

Fix the problem by modifying pfr_ina_commit() to transfer counters
from or to the shadow table.

Reported by: sigsys@gmail.com

Test Plan

Regression tests pass. I will write a test case for this if the code change seems ok.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable