Page MenuHomeFreeBSD

pf: Fix table entry counter toggling
ClosedPublic

Authored by markj on Dec 1 2020, 6:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 23, 8:18 AM
Unknown Object (File)
Tue, Nov 18, 8:35 PM
Unknown Object (File)
Tue, Nov 18, 1:04 AM
Unknown Object (File)
Nov 6 2025, 3:16 AM
Unknown Object (File)
Nov 3 2025, 1:00 PM
Unknown Object (File)
Nov 3 2025, 12:55 PM
Unknown Object (File)
Nov 3 2025, 12:54 PM
Unknown Object (File)
Nov 3 2025, 12:53 PM

Details

Summary

When updating a table, pf will keep table entry structures corresponding
to addresses that are in both of the old and new tables. However, the
update may also enable or disable per-entry counters which are allocated
separately. Thus when toggling PFR_TFLAG_COUNTERS, the entries may be
missing counters or may have unused counters allocated.

Fix the problem by modifying pfr_ina_commit() to transfer counters
from or to the shadow table.

Reported by: sigsys@gmail.com

Test Plan

Regression tests pass. I will write a test case for this if the code change seems ok.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable