Page MenuHomeFreeBSD

Uses/cmake.mk: Replace CMAKE_ENV with CONFIGURE_ENV.
ClosedPublic

Authored by rakuco on Aug 17 2015, 9:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 19, 7:30 AM
Unknown Object (File)
Jan 14 2025, 3:44 AM
Unknown Object (File)
Jan 11 2025, 7:19 PM
Unknown Object (File)
Nov 26 2024, 6:53 PM
Unknown Object (File)
Nov 25 2024, 5:25 AM
Unknown Object (File)
Nov 24 2024, 10:13 AM
Unknown Object (File)
Nov 23 2024, 11:05 AM
Unknown Object (File)
Nov 20 2024, 1:23 AM
Subscribers
None

Details

Summary

Instead of defining a variable that is almost always based on CONFIGURE_ENV, just use CONFIGURE_ENV directly. This also matches the behavior of other ports that do not use autotools (so most ports can just worry about CONFIGURE_ENV). Additionally, the fact that we do not use ?= means we do not have problems if another file in Uses/ needs to set CONFIGURE_ENV (with CMAKE_ENV, the order of the arguments to USES would matter).

Test Plan

All mentioned ports have been tested with the change and build fine on 9.3-i386.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 139
Build 139: arc lint + arc unit

Event Timeline

rakuco retitled this revision from to Uses/cmake.mk: Replace CMAKE_ENV with CONFIGURE_ENV..
rakuco updated this object.
rakuco edited the test plan for this revision. (Show Details)
makc edited edge metadata.
makc added inline comments.
math/eigen3/Makefile
17

LOCALBASE is incorrectly used here instead of PREFIX

This revision is now accepted and ready to land.Aug 17 2015, 10:38 PM
rakuco added inline comments.
math/eigen3/Makefile
17

Fixed in rP394563.

This revision was automatically updated to reflect the committed changes.