Page MenuHomeFreeBSD

Uses/cmake.mk: Replace CMAKE_ENV with CONFIGURE_ENV.
ClosedPublic

Authored by rakuco on Aug 17 2015, 9:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 1:23 AM
Unknown Object (File)
Tue, Nov 19, 5:02 PM
Unknown Object (File)
Tue, Nov 19, 2:01 AM
Unknown Object (File)
Sat, Nov 16, 8:43 AM
Unknown Object (File)
Sun, Nov 10, 4:05 AM
Unknown Object (File)
Sat, Nov 9, 11:29 PM
Unknown Object (File)
Thu, Nov 7, 8:37 AM
Unknown Object (File)
Tue, Oct 29, 6:39 AM
Subscribers
None

Details

Summary

Instead of defining a variable that is almost always based on CONFIGURE_ENV, just use CONFIGURE_ENV directly. This also matches the behavior of other ports that do not use autotools (so most ports can just worry about CONFIGURE_ENV). Additionally, the fact that we do not use ?= means we do not have problems if another file in Uses/ needs to set CONFIGURE_ENV (with CMAKE_ENV, the order of the arguments to USES would matter).

Test Plan

All mentioned ports have been tested with the change and build fine on 9.3-i386.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rakuco retitled this revision from to Uses/cmake.mk: Replace CMAKE_ENV with CONFIGURE_ENV..
rakuco updated this object.
rakuco edited the test plan for this revision. (Show Details)
makc edited edge metadata.
makc added inline comments.
math/eigen3/Makefile
17 ↗(On Diff #8015)

LOCALBASE is incorrectly used here instead of PREFIX

This revision is now accepted and ready to land.Aug 17 2015, 10:38 PM
rakuco added inline comments.
math/eigen3/Makefile
17 ↗(On Diff #8015)

Fixed in rP394563.

This revision was automatically updated to reflect the committed changes.