Page MenuHomeFreeBSD

Uses/cmake.mk: Replace CMAKE_ENV with CONFIGURE_ENV.
ClosedPublic

Authored by rakuco on Aug 17 2015, 9:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 4, 12:01 AM
Unknown Object (File)
Mon, Nov 13, 11:44 AM
Unknown Object (File)
Fri, Nov 10, 11:28 PM
Unknown Object (File)
Wed, Nov 8, 8:54 PM
Unknown Object (File)
Mon, Nov 6, 11:18 AM
Unknown Object (File)
Oct 31 2023, 10:52 PM
Unknown Object (File)
Oct 31 2023, 10:52 PM
Unknown Object (File)
Oct 31 2023, 10:52 PM
Subscribers
None

Details

Summary

Instead of defining a variable that is almost always based on CONFIGURE_ENV, just use CONFIGURE_ENV directly. This also matches the behavior of other ports that do not use autotools (so most ports can just worry about CONFIGURE_ENV). Additionally, the fact that we do not use ?= means we do not have problems if another file in Uses/ needs to set CONFIGURE_ENV (with CMAKE_ENV, the order of the arguments to USES would matter).

Test Plan

All mentioned ports have been tested with the change and build fine on 9.3-i386.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 139
Build 139: arc lint + arc unit

Event Timeline

rakuco retitled this revision from to Uses/cmake.mk: Replace CMAKE_ENV with CONFIGURE_ENV..
rakuco updated this object.
rakuco edited the test plan for this revision. (Show Details)
makc edited edge metadata.
makc added inline comments.
math/eigen3/Makefile
17

LOCALBASE is incorrectly used here instead of PREFIX

This revision is now accepted and ready to land.Aug 17 2015, 10:38 PM
rakuco added inline comments.
math/eigen3/Makefile
17

Fixed in rP394563.

This revision was automatically updated to reflect the committed changes.