Fix vnode leak with msdosfs_rename()
ClosedPublic
Actions

Authored by trasz on Nov 23 2020, 1:55 PM.

Details

Reviewers

Commits

rGf6082ba9d2e0: msdosfs: fix vnode leak with msdosfs_rename()
rGb8073b3c7434: msdosfs: fix vnode leak with msdosfs_rename()

Summary

Fix vnode leak with msdosfs_rename(), failing due to disappearing
source file.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 34980
Build 31973: arc lint + arc unit

Event Timeline

trasz created this revision.Nov 23 2020, 1:55 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 23 2020, 1:55 PM

trasz requested review of this revision.Nov 23 2020, 1:55 PM

trasz added a subscriber: NetApp.Nov 23 2020, 1:56 PM

Harbormaster completed remote builds in B34980: Diff 79897.Nov 23 2020, 1:56 PM

Do you have repro ? Did you sent it to pho ?

sys/fs/msdosfs/msdosfs_vnops.c
1129	I must admit that this is an exemplary case for a useless comment repeating the code.

This revision is now accepted and ready to land.Nov 23 2020, 2:23 PM

(Tinderboxed.)

In D27338#610605, @kib wrote:

Do you have repro ? Did you sent it to pho ?

Unfortunately not. My plan is to ask pho@ to test the msdosfs changes together.

I agree about the comment; will try to improve it :-)

Closed by commit rGb8073b3c7434: msdosfs: fix vnode leak with msdosfs_rename() (authored by trasz). · Explain WhyJan 31 2021, 9:41 PM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rGb8073b3c7434: msdosfs: fix vnode leak with msdosfs_rename().

trasz added a commit: rGf6082ba9d2e0: msdosfs: fix vnode leak with msdosfs_rename().Mar 2 2021, 6:43 PM

Revision Contents
Changeset List

Path

Size

sys/

fs/

msdosfs/

msdosfs_vnops.c

8 lines

Diff 79897

View Options

sys/fs/msdosfs/msdosfs_vnops.c

Fix vnode leak with msdosfs_rename()ClosedPublicActions