Page MenuHomeFreeBSD

Fix vnode leak with msdosfs_rename()
ClosedPublic

Authored by trasz on Nov 23 2020, 1:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 18 2024, 7:19 AM
Unknown Object (File)
Feb 9 2024, 9:46 AM
Unknown Object (File)
Feb 8 2024, 3:24 AM
Unknown Object (File)
Dec 22 2023, 11:29 PM
Unknown Object (File)
Dec 18 2023, 1:36 PM
Unknown Object (File)
Dec 12 2023, 1:58 PM
Unknown Object (File)
Nov 13 2023, 12:24 PM
Unknown Object (File)
Oct 17 2023, 6:35 AM
Subscribers

Details

Summary

Fix vnode leak with msdosfs_rename(), failing due to disappearing
source file.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34980
Build 31973: arc lint + arc unit

Event Timeline

trasz requested review of this revision.Nov 23 2020, 1:55 PM

Do you have repro ? Did you sent it to pho ?

sys/fs/msdosfs/msdosfs_vnops.c
1129

I must admit that this is an exemplary case for a useless comment repeating the code.

This revision is now accepted and ready to land.Nov 23 2020, 2:23 PM
In D27338#610605, @kib wrote:

Do you have repro ? Did you sent it to pho ?

Unfortunately not. My plan is to ask pho@ to test the msdosfs changes together.

I agree about the comment; will try to improve it :-)

This revision was automatically updated to reflect the committed changes.