Page MenuHomeFreeBSD

Fix vnode leak with msdosfs_rename()
ClosedPublic

Authored by trasz on Nov 23 2020, 1:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 23, 2:01 PM
Unknown Object (File)
Sun, Sep 21, 11:20 AM
Unknown Object (File)
Aug 14 2025, 9:21 PM
Unknown Object (File)
Jul 29 2025, 8:50 AM
Unknown Object (File)
Jul 29 2025, 5:29 AM
Unknown Object (File)
Jul 28 2025, 10:00 PM
Unknown Object (File)
Jul 24 2025, 12:01 AM
Unknown Object (File)
Jun 22 2025, 3:54 PM
Subscribers

Details

Summary

Fix vnode leak with msdosfs_rename(), failing due to disappearing
source file.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trasz requested review of this revision.Nov 23 2020, 1:55 PM

Do you have repro ? Did you sent it to pho ?

sys/fs/msdosfs/msdosfs_vnops.c
1129

I must admit that this is an exemplary case for a useless comment repeating the code.

This revision is now accepted and ready to land.Nov 23 2020, 2:23 PM
In D27338#610605, @kib wrote:

Do you have repro ? Did you sent it to pho ?

Unfortunately not. My plan is to ask pho@ to test the msdosfs changes together.

I agree about the comment; will try to improve it :-)

This revision was automatically updated to reflect the committed changes.