Page MenuHomeFreeBSD

Fix vnode leak with msdosfs_rename()
ClosedPublic

Authored by trasz on Nov 23 2020, 1:55 PM.

Details

Summary

Fix vnode leak with msdosfs_rename(), failing due to disappearing
source file.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

trasz requested review of this revision.Nov 23 2020, 1:55 PM

Do you have repro ? Did you sent it to pho ?

sys/fs/msdosfs/msdosfs_vnops.c
1128

I must admit that this is an exemplary case for a useless comment repeating the code.

This revision is now accepted and ready to land.Nov 23 2020, 2:23 PM
In D27338#610605, @kib wrote:

Do you have repro ? Did you sent it to pho ?

Unfortunately not. My plan is to ask pho@ to test the msdosfs changes together.

I agree about the comment; will try to improve it :-)