Differential D27219

Refactor rib iterator functions.
ClosedPublic
Actions

Authored by melifaro on Nov 14 2020, 9:28 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 9, 9:23 PM

	Unknown Object (File)
	Sat, Nov 29, 8:18 PM

	Unknown Object (File)
	Sat, Nov 29, 4:09 AM

	Unknown Object (File)
	Wed, Nov 26, 5:51 PM

	Unknown Object (File)
	Fri, Nov 14, 2:15 AM

	Unknown Object (File)
	Nov 10 2025, 11:28 PM

	Unknown Object (File)
	Nov 4 2025, 4:04 AM

	Unknown Object (File)
	Oct 26 2025, 1:40 PM

Subscribers

Details

Reviewers

None

Group Reviewers

Commits

rS367941: Refactor rib iterator functions.

Summary

Make rib_walk() order of arguments consistent with the rest of RIB api
Add rib_walk_ext() allowing to exec callback before/after iteration.
Rename rt_foreach_fib_walk_del -> rib_foreach_table_walk_del
Rename rt_forach_fib_walk -> rib_foreach_table_walk
Move rib_foreach_table_walk{_del} to route/route_helpers.c
Slightly refactor rib_foreach_table_walk{_del} to make the implementation consistent and prepare for upcoming iterator optimizations.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

melifaro created this revision.Nov 14 2020, 9:28 PM

Herald added a subscriber: ae. · View Herald TranscriptNov 14 2020, 9:28 PM

melifaro requested review of this revision.Nov 14 2020, 9:28 PM

Harbormaster completed remote builds in B34799: Diff 79555.Nov 14 2020, 9:28 PM

melifaro added a reviewer: network.Nov 14 2020, 9:28 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 22 2020, 8:21 PM

Closed by commit rS367941: Refactor rib iterator functions. (authored by melifaro). · Explain Why

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rS367941: Refactor rib iterator functions..

Herald added subscribers: bz, imp. · View Herald TranscriptNov 22 2020, 8:21 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

net/

4 lines

79 lines

route/

22 lines

2 lines

route_helpers.c

85 lines

netinet/

2 lines

netinet6/

2 lines

Diff 79866

head/sys/net/route.h

Loading...

head/sys/net/route.c

Loading...

head/sys/net/route/route_ctl.h

Loading...

head/sys/net/route/route_ctl.c

Loading...

head/sys/net/route/route_helpers.c

Loading...

head/sys/netinet/in_rmx.c

Loading...

head/sys/netinet6/nd6_rtr.c

Loading...