Page MenuHomeFreeBSD

Fix declaration of rn_addmask()
ClosedPublic

Authored by mhorne on Oct 30 2020, 6:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 6:10 AM
Unknown Object (File)
Tue, Dec 10, 6:46 PM
Unknown Object (File)
Fri, Dec 6, 6:52 AM
Unknown Object (File)
Thu, Dec 5, 6:06 PM
Unknown Object (File)
Sun, Dec 1, 9:46 PM
Unknown Object (File)
Thu, Nov 28, 11:02 PM
Unknown Object (File)
Oct 23 2024, 6:55 AM
Unknown Object (File)
Oct 7 2024, 4:09 AM
Subscribers

Details

Summary

The function is defined with global visibility, but the declaration is
not. Move it to the public header.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34608
Build 31697: arc lint + arc unit

Event Timeline

Do you by any chance have a usecase which requires exposing rn_addmask? If not, I'd rather prefer to have it the other way round - making the definition static.

Do you by any chance have a usecase which requires exposing rn_addmask? If not, I'd rather prefer to have it the other way round - making the definition static.

Good question. NetApp has some additions to radix_mpath.c to be upstreamed that make use of this function, but it's possible that they should be using rn_lookup() instead. I'll have to investigate further before I can give a definitive answer.

Do you by any chance have a usecase which requires exposing rn_addmask? If not, I'd rather prefer to have it the other way round - making the definition static.

Good question. NetApp has some additions to radix_mpath.c to be upstreamed that make use of this function, but it's possible that they should be using rn_lookup() instead. I'll have to investigate further before I can give a definitive answer.

I guess it's worth checking it as we don't use radix_mpath.c anymore. In fact, I forgot to remove it :-)

I guess it's worth checking it as we don't use radix_mpath.c anymore. In fact, I forgot to remove it :-)

Ahhh, well that changes it then. That was removed recently with D26449 I guess.

Make rn_addmask static instead.

This revision is now accepted and ready to land.Nov 8 2020, 10:17 AM
This revision was automatically updated to reflect the committed changes.