The function is defined with global visibility, but the declaration is
not. Move it to the public header.
Details
Details
- Reviewers
melifaro - Commits
- rS367494: Fix definition of rn_addmask()
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Do you by any chance have a usecase which requires exposing rn_addmask? If not, I'd rather prefer to have it the other way round - making the definition static.
Comment Actions
Good question. NetApp has some additions to radix_mpath.c to be upstreamed that make use of this function, but it's possible that they should be using rn_lookup() instead. I'll have to investigate further before I can give a definitive answer.
Comment Actions
I guess it's worth checking it as we don't use radix_mpath.c anymore. In fact, I forgot to remove it :-)