Page MenuHomeFreeBSD

Fix declaration of rn_addmask()
ClosedPublic

Authored by mhorne on Oct 30 2020, 6:01 PM.

Details

Summary

The function is defined with global visibility, but the declaration is
not. Move it to the public header.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Do you by any chance have a usecase which requires exposing rn_addmask? If not, I'd rather prefer to have it the other way round - making the definition static.

Do you by any chance have a usecase which requires exposing rn_addmask? If not, I'd rather prefer to have it the other way round - making the definition static.

Good question. NetApp has some additions to radix_mpath.c to be upstreamed that make use of this function, but it's possible that they should be using rn_lookup() instead. I'll have to investigate further before I can give a definitive answer.

Do you by any chance have a usecase which requires exposing rn_addmask? If not, I'd rather prefer to have it the other way round - making the definition static.

Good question. NetApp has some additions to radix_mpath.c to be upstreamed that make use of this function, but it's possible that they should be using rn_lookup() instead. I'll have to investigate further before I can give a definitive answer.

I guess it's worth checking it as we don't use radix_mpath.c anymore. In fact, I forgot to remove it :-)

I guess it's worth checking it as we don't use radix_mpath.c anymore. In fact, I forgot to remove it :-)

Ahhh, well that changes it then. That was removed recently with D26449 I guess.

Make rn_addmask static instead.

This revision is now accepted and ready to land.Nov 8 2020, 10:17 AM
This revision was automatically updated to reflect the committed changes.