Cleanup of net/if_media.c
ClosedPublic
Actions

Authored by kib on Oct 31 2020, 11:58 PM.

Details

Reviewers

Commits

rS367252: net/if_media.c: improve IFMEDIA_DEBUG output.
rS367251: Cleanup of net/if_media.c: simplify cleanup loop in ifmedia_removeall().
rS367250: Cleanup of net/if_media.c: some style.
rS367249: Cleanup of net/if_media.c: switch to ANSI C function definitions.

Summary

Style.
Switch to ANSI C function definitions.
Improve debug messages, mostly by providing consistent formatting for numbers.

Sponsored by: Mellanox Technologies / NVidia Networking.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Oct 31 2020, 11:58 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptOct 31 2020, 11:58 PM

kib requested review of this revision.Oct 31 2020, 11:58 PM

Harbormaster completed remote builds in B34538: Diff 79023.Oct 31 2020, 11:58 PM

kib added inline comments.Oct 31 2020, 11:58 PM

sys/net/if_media.c
72 ↗	(On Diff #79023)	This will not be committed.

No functional change I presume.

This revision is now accepted and ready to land.Nov 1 2020, 1:42 PM

Closed by commit rS367249: Cleanup of net/if_media.c: switch to ANSI C function definitions. (authored by kib). · Explain WhyNov 1 2020, 4:25 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rS367249: Cleanup of net/if_media.c: switch to ANSI C function definitions..

kib added a commit: rS367250: Cleanup of net/if_media.c: some style..Nov 1 2020, 4:30 PM

kib added a commit: rS367251: Cleanup of net/if_media.c: simplify cleanup loop in ifmedia_removeall()..Nov 1 2020, 4:36 PM

kib added a commit: rS367252: net/if_media.c: improve IFMEDIA_DEBUG output..Nov 1 2020, 4:38 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

net/

if_media.c

41 lines

Diff 79036

View Options

Cleanup of net/if_media.cClosedPublicActions