Page MenuHomeFreeBSD
Differential D27012

linux(4): Emulate Linux SOL_SOCKET:SO_PASSCRED
ClosedPublic
Actions

Authored by cem on Oct 29 2020, 7:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 25, 5:25 AM
Unknown Object (File)
Fri, Jul 24, 3:10 AM
Unknown Object (File)
Wed, Jul 22, 4:26 PM
Unknown Object (File)
Sun, Jul 19, 8:42 PM
Unknown Object (File)
Sun, Jul 12, 5:18 PM
Unknown Object (File)
Sun, Jul 5, 8:39 AM
Unknown Object (File)
Jun 18 2026, 3:46 AM
Unknown Object (File)
May 31 2026, 1:30 PM
View All Files
Subscribers
imp

Details

Reviewers
markj
trasz
Commits
rS367288: linux(4): Emulate Linux SOL_SOCKET:SO_PASSCRED
Summary

This is required by some major linux applications, such as Chrome and
Firefox. (As well as Electron-using applications, which are essentially
a bundled version of Chrome.)

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34514
Build 31612: arc lint + arc unit

Event Timeline

cem requested review of this revision.Oct 29 2020, 7:57 PM
cem created this revision.
Harbormaster completed remote builds in B34485: Diff 78924.Oct 29 2020, 7:57 PM
cem added a parent revision: D27011: unix(4): Add SOL_LOCAL:LOCAL_PASSCRED.Oct 29 2020, 7:57 PM
trasz mentioned this in D27011: unix(4): Add SOL_LOCAL:LOCAL_PASSCRED.Oct 29 2020, 8:42 PM
markj accepted this revision.Oct 30 2020, 2:22 PM
markj added inline comments.
sys/compat/linux/linux_socket.c
1556

Make it the first case statement rather than the last, like you did above?

This revision is now accepted and ready to land.Oct 30 2020, 2:22 PM
cem added inline comments.Oct 30 2020, 4:43 PM
sys/compat/linux/linux_socket.c
1556

Will do

cem updated this revision to Diff 78975.Oct 30 2020, 6:33 PM
cem marked an inline comment as done.
  • Reorder second switch case to match first; no functional change.
This revision now requires review to proceed.Oct 30 2020, 6:33 PM
Harbormaster completed remote builds in B34514: Diff 78975.Oct 30 2020, 6:33 PM
markj accepted this revision.Nov 2 2020, 2:34 PM
This revision is now accepted and ready to land.Nov 2 2020, 2:34 PM
cem updated this revision to Diff 79103.Nov 2 2020, 9:19 PM

Rebase on parent revision changes.

This revision now requires review to proceed.Nov 2 2020, 9:19 PM
Harbormaster completed remote builds in B34587: Diff 79103.Nov 2 2020, 9:19 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 3 2020, 1:19 AM
Closed by commit rS367288: linux(4): Emulate Linux SOL_SOCKET:SO_PASSCRED (authored by cem). · Explain Why
This revision was automatically updated to reflect the committed changes.
cem added a commit: rS367288: linux(4): Emulate Linux SOL_SOCKET:SO_PASSCRED.
Herald added a subscriber: imp. · View Herald TranscriptNov 3 2020, 1:19 AM

Revision Contents
Changeset List

PathSize
sys/
compat/
linux/
8 lines

Diff 78975

View Options

sys/compat/linux/linux_socket.c

Loading...