Page MenuHomeFreeBSD
Differential D26946

fetch(1): Add EXAMPLES section
ClosedPublic
Actions

Authored by fernape on Oct 25 2020, 6:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 3, 7:26 PM
Unknown Object (File)
Tue, Dec 3, 7:26 PM
Unknown Object (File)
Tue, Dec 3, 7:26 PM
Unknown Object (File)
Tue, Dec 3, 7:26 PM
Unknown Object (File)
Tue, Dec 3, 7:25 PM
Unknown Object (File)
Tue, Dec 3, 7:06 PM
Unknown Object (File)
Nov 29 2024, 2:07 PM
Unknown Object (File)
Nov 25 2024, 3:20 AM
View All 47 Files
Subscribers
bcr
imp
Contributor Reviews (src)

Details

Reviewers
0mp
Group Reviewers
manpages
Commits
rS367160: fetch(1): Fix style
rS367141: fetch(1): Add EXAMPLES section
Summary

Add a few examples covering flags: 1 R a o q r s v

Test Plan
  • mandoc -Tlint clean
  • igor clean
  • aspell happy
  • man ./fetch.1 renders the page properly

Note that due to the nature of fetch(1)'s output, a few lines go over the 80
column limit.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34493
Build 31592: arc lint + arc unit

Event Timeline

fernape created this revision.Oct 25 2020, 6:46 PM
Herald added a reviewer: manpages. · View Herald TranscriptOct 25 2020, 6:46 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript
fernape requested review of this revision.Oct 25 2020, 6:46 PM
Harbormaster completed remote builds in B34384: Diff 78747.Oct 25 2020, 6:47 PM
bcr accepted this revision as: manpages.Oct 29 2020, 4:45 PM
bcr added a subscriber: bcr.

Looks good to me. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Oct 29 2020, 6:35 PM
Closed by commit rS367141: fetch(1): Add EXAMPLES section (authored by fernape). · Explain Why
This revision was automatically updated to reflect the committed changes.
fernape added a commit: rS367141: fetch(1): Add EXAMPLES section.
fernape added a comment.Oct 29 2020, 6:39 PM

Thanks for the review!

fernape reopened this revision.Oct 30 2020, 7:40 AM

Reopening to be able to update revision

fernape updated this revision to Diff 78941.Oct 30 2020, 7:41 AM

Some concerns were raised with this commit.

  • Break line in .Ql macro
  • Use .Pa instead of .Ql. It is done in cp(1) even for made up names so I suppose it is OK to do it here.
  • Change \\ to \e
Harbormaster completed remote builds in B34493: Diff 78941.Oct 30 2020, 7:41 AM
0mp accepted this revision.Oct 30 2020, 9:18 AM
This revision is now accepted and ready to land.Oct 30 2020, 9:18 AM
Closed by commit rS367160: fetch(1): Fix style (authored by fernape). · Explain WhyOct 30 2020, 9:48 AM
This revision was automatically updated to reflect the committed changes.
fernape added a commit: rS367160: fetch(1): Fix style.
fernape added a comment.Oct 30 2020, 9:54 AM

Thanks Mateusz!

Revision Contents
Changeset List

PathSize
usr.bin/
fetch/
13 lines

Diff 78941

View Options

usr.bin/fetch/fetch.1

Loading...