clang-format: Avoid breaking after the opening paren of function definitions
ClosedPublic
Actions

Authored by arichardson on Oct 27 2020, 4:39 PM.

Details

Reviewers

emaste
cem
dim

Commits

rS367100: clang-format: Avoid breaking after the opening paren of function definitions

Summary

This depends on https://reviews.llvm.org/D90246, but once that has landed
clang-format will no longer format code like this:

int
myfunction(
    int param1, int param2, int param2)
{
   ...
}

and instead create the following:

int
myfunction(int param1, int param2,
    int param2)
{
   ...
}

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 34421
Build 31525: arc lint + arc unit

Event Timeline

arichardson requested review of this revision.Oct 27 2020, 4:39 PM

arichardson created this revision.

Harbormaster completed remote builds in B34421: Diff 78823.Oct 27 2020, 4:39 PM

LGTM. You could go ahead and commit the changes that work with current clang-format separately, if you're waiting on upstream for the AllowAllArgumentsOnNextLine.

Do you know if there is a mechanism to get the type and qualifiers on an independent line before the function name? That jumps out as a missing piece in both examples. Thanks!

cem accepted this revision.Oct 27 2020, 4:56 PM

This revision is now accepted and ready to land.Oct 27 2020, 4:56 PM

In D26978#601758, @cem wrote:

LGTM. You could go ahead and commit the changes that work with current clang-format separately, if you're waiting on upstream for the AllowAllArgumentsOnNextLine.

Do you know if there is a mechanism to get the type and qualifiers on an independent line before the function name? That jumps out as a missing piece in both examples. Thanks!

That was a bug in my commit description, AlwaysBreakAfterReturnType: TopLevelDefinitions will ensure that the return type is on a separate line.

emaste accepted this revision.Oct 27 2020, 6:46 PM

Closed by commit rS367100: clang-format: Avoid breaking after the opening paren of function definitions (authored by arichardson). · Explain WhyOct 28 2020, 11:54 AM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS367100: clang-format: Avoid breaking after the opening paren of function definitions.

Herald added a subscriber: imp. · View Herald TranscriptOct 28 2020, 11:54 AM