Differential D26845

Further refinements of ptsname_r(3) interface:
ClosedPublic
Actions

Authored by delphij on Oct 18 2020, 7:47 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, May 10, 6:10 AM

	Unknown Object (File)
	Sat, May 9, 2:56 PM

	Unknown Object (File)
	Fri, May 8, 6:00 PM

	Unknown Object (File)
	Fri, May 1, 11:16 PM

	Unknown Object (File)
	Wed, Apr 29, 10:27 PM

	Unknown Object (File)
	Tue, Apr 28, 6:45 PM

	Unknown Object (File)
	Mon, Apr 27, 4:15 AM

	Unknown Object (File)
	Tue, Apr 21, 8:59 AM

Subscribers

Details

Reviewers

kib
jilles
emaste

Commits

rS366866: Further refinements of ptsname_r(3) interface:

Summary

Hide ptsname_r under __BSD_VISIBLE for now as the specification is not finalized at this time.
Keep Symbol.map sorted.
Avoid the interposing of ptsname_r(3) from an user application from breaking ptsname(3) by making the implementation a static method and call the static function from ptsname(3) instead.

Reported by: kib

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 34246
Build 31390: arc lint + arc unit

Event Timeline

delphij requested review of this revision.Oct 18 2020, 7:47 PM

delphij created this revision.

Harbormaster completed remote builds in B34246: Diff 78393.Oct 18 2020, 7:47 PM

jilles added inline comments.Oct 18 2020, 9:05 PM

include/stdlib.h
239	This should probably go with the other function prototypes in a logical order (it seems mostly alphabetical now).

kib added inline comments.Oct 18 2020, 9:08 PM

lib/libc/stdlib/ptsname.c
104	Why do you want to make the function weak ?
106	It is better to Make __ptsname_r non-static (but do not add it to Symbol.map) Define ptsname_r as an alias for __ptsname_r. Look above how e.g. grantpt is defined. Then you do not need this trivial wrapper.

Address reviewer comments.

Harbormaster completed remote builds in B34254: Diff 78410.Oct 19 2020, 4:30 AM

Please take another look, thanks!

kib accepted this revision.Oct 19 2020, 7:09 AM

This revision is now accepted and ready to land.Oct 19 2020, 7:09 AM

jilles accepted this revision.Oct 19 2020, 7:53 PM

Closed by commit rS366866: Further refinements of ptsname_r(3) interface: (authored by delphij). · Explain WhyOct 20 2020, 1:30 AM

This revision was automatically updated to reflect the committed changes.

delphij added a commit: rS366866: Further refinements of ptsname_r(3) interface:.

Herald added a subscriber: imp. · View Herald TranscriptOct 20 2020, 1:30 AM

Revision Contents
Changeset List

Path

Size

include/

2 lines

lib/

libc/

stdlib/

2 lines

28 lines

Diff 78393

include/stdlib.h

Loading...

lib/libc/stdlib/Symbol.map

Loading...

lib/libc/stdlib/ptsname.c

Loading...