Page MenuHomeFreeBSD
Differential D26774

[llvm] Use 32 bit atomic on freebsd mips
ClosedPublic
Actions

Authored by adrian on Oct 13 2020, 10:54 PM.
Tags
None
Referenced Files
F175826709: D26774.id78384.diff
Tue, Oct 13, 4:55 PM
F175824599: D26774.id78199.diff
Tue, Oct 13, 4:34 PM
F175823196: D26774.diff
Tue, Oct 13, 4:18 PM
Unknown Object (File)
Tue, Sep 29, 3:45 PM
Unknown Object (File)
Mon, Sep 21, 7:26 AM
Unknown Object (File)
Mon, Sep 21, 6:57 AM
Unknown Object (File)
Mon, Sep 21, 6:54 AM
Unknown Object (File)
Fri, Sep 18, 7:01 AM
View All Files
Subscribers
imp

Details

Reviewers
dim
emaste
Commits
rG3720e5486934: [libcxx] Fix atomic type for mips32 on gcc to work w/out needing libatomic
rS366814: [libcxx] Fix atomic type for mips32 on gcc to work w/out needing libatomic
Summary

gcc for mips32 doesn't include libatomic and doesn't generate
atomic sequences; so this just fails to link.

Instead, just use 32 bit for mips32/mips64.

(I haven't found a nice way to detect 32 or 64 bit mips here
without other header pollution, but it should be fine for freebsd/mips.)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adrian created this revision.Oct 13 2020, 10:54 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 13 2020, 10:54 PM
adrian requested review of this revision.Oct 13 2020, 10:54 PM
Harbormaster completed remote builds in B34149: Diff 78199.Oct 13 2020, 10:54 PM
adrian added reviewers: dim, emaste.Oct 13 2020, 10:55 PM
dim accepted this revision.Oct 16 2020, 6:58 PM

I think this is fine for now. Upstream will want to centralize the define somewhere in __config, but we can take that discussion there.

This revision is now accepted and ready to land.Oct 16 2020, 6:58 PM
Closed by commit rS366814: [libcxx] Fix atomic type for mips32 on gcc to work w/out needing libatomic (authored by adrian). · Explain WhyOct 18 2020, 5:31 PM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rS366814: [libcxx] Fix atomic type for mips32 on gcc to work w/out needing libatomic.
dim added a commit: rG3720e5486934: [libcxx] Fix atomic type for mips32 on gcc to work w/out needing libatomic.Dec 22 2021, 10:09 AM
dim mentioned this in D38132: libcxx: Implement atomic::wait/wake using _umtx_op(2) ) for 64bit arches.Jan 20 2023, 3:56 PM
jrtc27 mentioned this in D38178: libcxx: use __SIZEOF_LONG__ == 8 instead of __LP64__.Jan 25 2023, 1:57 AM

Revision Contents
Changeset List

PathSize
head/
contrib/
llvm-project/
libcxx/
include/
4 lines

Diff 78384

View Options

head/contrib/llvm-project/libcxx/include/atomic

Loading...